feat: add competitive_enabled and worktree path/branch templates (§7.2, §7.3-7.4)#189
Merged
maystudios merged 1 commit intomainfrom Mar 25, 2026
Merged
feat: add competitive_enabled and worktree path/branch templates (§7.2, §7.3-7.4)#189maystudios merged 1 commit intomainfrom
maystudios merged 1 commit intomainfrom
Conversation
…onfig Fixes audit gaps §7.2 (competitive_enabled missing from execution config) and §7.3-7.4 (path_template/branch_template missing from worktrees config). - Add `competitive_enabled: boolean` to MaxsimConfig.execution interface and DEFAULT_CONFIG - Add `path_template: string` and `branch_template: string` to MaxsimConfig.worktrees interface and DEFAULT_CONFIG - Mirror both fields in templates/templates/config.json - Add unit test coverage for both new defaults in types.test.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 5.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Pull request overview
This PR updates the MaxsimCLI configuration schema and its shipped templates to include missing defaults needed by the competitive execution and worktree templating features referenced in the workflows/spec.
Changes:
- Add
execution.competitive_enabled(defaultfalse) toMaxsimConfigandDEFAULT_CONFIG. - Add
worktrees.path_templateandworktrees.branch_template(with defaults) toMaxsimConfigandDEFAULT_CONFIG. - Mirror these defaults into
templates/templates/config.jsonand add unit tests asserting the new defaults.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| templates/templates/config.json | Adds new config defaults (competitive_enabled, worktree templates) and updates template version. |
| packages/cli/tests/unit/types.test.ts | Adds assertions that the new defaults exist and match expected values. |
| packages/cli/src/core/version.ts | Bumps the injected CLI version constant to 5.13.1. |
| packages/cli/src/core/types.ts | Extends MaxsimConfig and DEFAULT_CONFIG with the new config keys and defaults. |
| packages/cli/README.md | Documents additional slash commands and updates the Planner description to reflect GitHub-plan-comments behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
competitive_enabled: booleantoMaxsimConfig.executioninterface andDEFAULT_CONFIG(fixes audit gap §7.2)path_template: stringandbranch_template: stringtoMaxsimConfig.worktreesinterface andDEFAULT_CONFIG(fixes audit gaps §7.3-7.4)templates/templates/config.jsontypes.test.tsto cover the new defaultsTest plan
npx vitest run— 539 tests pass (17/18 suites;templates.test.tsfailure is pre-existing, requires built dist)npm run build— TypeScript compiles cleanlynpm run lint— no new lint errors introduced (9 warnings + 28 infos are all pre-existing)🤖 Generated with Claude Code