Remove underscores and capitals from all JSON options #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a followup to my earlier Pydantic schemas PR. It fixes all of the hundreds of warnings that are now being printed about options with incorrectly formatted names.
There should (TM) be no code impacts from this change, as the configuration system will "normalize" names into the new format, so you can still e.g. override a option with the old name containing underscores. However, I did find a minor bug in the previous PR, which is that it didn't handle the case of options with underscores in their namespaces. That has been fixed here.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results