Open
Conversation
d-laub
modified the milestones:
Sequences exactly corresponding to input regions,
Spliced sequences
…I since these are generally never needed outside that context. feat: fully functional zero-copy splicing mechanics. fix: bug in rev and rev comp causing garbage output.
Open
Collaborator
Author
|
Hey Brian, this looks good! Thanks to @BradBalderson I just caught and fixed a bug in the reverse complement function. I think it would make sense that ~half of the sequences are way off with that bug. Can you try again with the latest commits? |
Collaborator
Without VCF normalisationUsing the VCF directly to create the GVL db, without any normalisation with Nucleotide-levelMUCH better seq sim for nuc level.
Amino acid-levelUnfortunately, still lots of stop codons: And actually the AA seq sim is a bit lower than before: With VCF normalisation[placeholder] |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
docs: fix version format to be vX.Y.Z
feat: initial prototype for splicing.
Splice regions together
Allow different definition of an overlapping variant to be fully exonic and not overlapping with splice sites a la Haplosaurus.
Update Dataset API (or maybe a new class) to reflect different shape and definition of a row.
Tests against Haplosaurus on 1kGP chr22 @bschilder
Performance issues, possibly from slow RC