fix region refresh on percentile/timeframe update#75
Open
agnoski wants to merge 1 commit intomda590:mainfrom
Open
fix region refresh on percentile/timeframe update#75agnoski wants to merge 1 commit intomda590:mainfrom
agnoski wants to merge 1 commit intomda590:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: sync region selection when percentile or timeframe updates
Summary
When the user changes percentile or timeframe, the app refetches latency data via updateData and replaces data. The available region keys come from Object.keys(data.data).
Previously, the useEffect that runs on [data] tried to merge newly appearing regions into selectedRegions. It did not reliably align the selection with the current payload when the set of regions changed in other ways, which led to a poor “refresh” experience after filter/timeframe updates.
This change replaces that merge logic with a simple intersection: keep only the previously selected regions that still exist in the latest data.data.
Behavior note
How to verify (manual)