Skip to content

ERC1155 ZKSync#168

Open
tenthirtyone wants to merge 3 commits intome-foundation:mainfrom
tenthirtyone:feature/solady-zksync-erc1155
Open

ERC1155 ZKSync#168
tenthirtyone wants to merge 3 commits intome-foundation:mainfrom
tenthirtyone:feature/solady-zksync-erc1155

Conversation

@tenthirtyone
Copy link
Copy Markdown
Contributor

Apologies, the solidity formatter hit some files.

Changes:

  • Update .gitignore with coverage and zkout dir
  • replaces
    import {ERC1155} from "solady/src/tokens/ERC1155.sol";
    with
    import {ERC1155} from "solady/src/tokens/ext/zksync/ERC1155.sol";
  • Bumps solady to 0.0.298 in foundry and npm

@nothing0012
Copy link
Copy Markdown
Contributor

good to know that solady has zksync ext.

does it work for non-zksync chains?

@tenthirtyone
Copy link
Copy Markdown
Contributor Author

@nothing0012 I think it depends. This contract should, but code related to zksync-specific features (system contracts, account abstraction, bridging) won't and some EVM opcodes are inefficient on zksync and not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants