superficial fix to date casting problem #108
Closed
pgulley wants to merge 3 commits intomediacloud:mainfrom
Closed
superficial fix to date casting problem #108pgulley wants to merge 3 commits intomediacloud:mainfrom
pgulley wants to merge 3 commits intomediacloud:mainfrom
Conversation
added 2 commits
October 8, 2025 12:24
Contributor
|
fix for #99 (for cross-reference) |
Member
Author
|
Seems test won't ever get the needed variables when running in the pull from fork context, so I'll run them locally and see how we do |
Member
Author
|
Added a test to poke this behavior, it passes. |
philbudne
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Longer term solution also involves patching at the server level to give better errors, but this will at least correct bad input going forward.