Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions lib/membrane/core/stalker.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ defmodule Membrane.Core.Stalker do
use GenServer
alias Membrane.{ComponentPath, Pad, Time}
require Membrane.Core.Utils, as: Utils
require Membrane.Logger

@unsafely_name_processes_for_observer Application.compile_env(
:membrane_core,
Expand Down Expand Up @@ -382,8 +383,25 @@ defmodule Membrane.Core.Stalker do
Process.send_after(self(), :scrape_metrics, @scrape_interval)
metrics = scrape_metrics(state)
timestamp = Time.milliseconds(System.monotonic_time(:millisecond) - state.init_time)
derivatives = calc_derivatives(metrics, timestamp, state)
send_to_subscribers(metrics ++ derivatives, :metrics, &{:metrics, &1, timestamp}, state)

cond do
state.timestamp == nil ->
send_to_subscribers(metrics, :metrics, &{:metrics, &1, timestamp}, state)

timestamp > state.timestamp ->
derivatives = calc_derivatives(metrics, timestamp, state)
send_to_subscribers(metrics ++ derivatives, :metrics, &{:metrics, &1, timestamp}, state)

true ->
# Since we're scraping metrics more or less every second, this should never
# happen - but it does, very rarely, for unknown reasons, and would lead
# to division by 0 in calc_derivatives.
# In such a weird case, we skip reporting metrics.
Membrane.Logger.debug("""
Not reporting metrics due to unexpected timestamp: #{timestamp}, previous timestamp: #{state.timestamp}
""")
end

{:noreply, %{state | metrics: Map.new(metrics), timestamp: timestamp}}
end

Expand Down Expand Up @@ -518,10 +536,6 @@ defmodule Membrane.Core.Stalker do
:ok
end

defp calc_derivatives(_new_metrics, _new_timestamp, %{timestamp: nil}) do
[]
end

defp calc_derivatives(new_metrics, new_timestamp, %{metrics: metrics, timestamp: timestamp}) do
dt_seconds = Time.as_seconds(new_timestamp - timestamp)

Expand Down
Loading