Open
Conversation
676ed08 to
1d14544
Compare
Owner
|
Thank you for this! We definitely should add some tests, and this is a great start! Sorry it's taken so long for me to get to this. I've now taken a closer look and first impressions are good. Now I just gotta make some time to pull this down and play with it a bit - I'm not sure yet when that will happen, but I'll go ahead and merge it as soon as I've had a chance to do that, and then we can improve on it as time+motivation+priority permits. |
Author
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some tests to the dependency functionality (mostly because I wanted to see how the dependency on suites behaves, exactly.)
Unfortunately, I was unable to figure out how to let multiple suites run programmatically, so I am delegating that to a CLI execution, which only gives me the return code (i.e. number of failed tests, effectively). I hope someone can find a better way.
I was also unable to verify the issued warnings, as I am not that deeply familiar with the internals of robot.