Skip to content

Grab ability range from wiki #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
and-zheng wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Grab ability range from wiki #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
030d52d
Grab ability range from wiki
zhen0275 Aug 17, 2023
b451ea8
Added 'range' to the Ability class
zhen0275 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lolstaticdata/champions/modelchampion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ class Ability(object):
angle: str
cast_time: str
effect_radius: str
range: str
target_range: str


Expand Down
1 change: 1 addition & 0 deletions lolstaticdata/champions/pull_champions_wiki.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ def _render_abilities(self, champion_name, abilities: List[HTMLAbilityWrapper])
angle=data.get("angle"),
cast_time=data.get("cast time"),
effect_radius=data.get("effect radius"),
range=data.get("range"),
target_range=data.get("target range"),
)
if ability.notes is not None and ability.notes.startswith("*"):
Expand Down