Unify nRF & ESP BLE interface #1277
Open
+840
−383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Stuff
Unified common code into SerialBLECommon.h base class
(it should reside in a helpers/bluetooth folder with all the nrf/esp files, but this PR is not for tidying up)
ESP32: Migrated from ESP32 BLE library to NimBLE - Re-pair could be needed! Full erase would be preferable for updating to clear out old BT library stuff from the flash. Factory reset does not clear that.
Connection
Dynamic connection parameters
Queue & Transfer Improvements
ESP32 Specific:
Well... everything that nRF had already are now in ESP's interface :) even "turbo mode"
The two platform's BLE interface is now more or less the same (with library dependent differences of course)