chore: remove protobufs git submodule#1025
Merged
danditomaso merged 1 commit intomeshtastic:mainfrom Mar 11, 2026
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the repository-level git submodule reference for packages/packages/protobufs, aiming to fully detach protobuf definitions from submodule management.
Changes:
- Removed the
packages/packages/protobufssubmodule entry (gitlink) from the repo. - Removed the corresponding submodule configuration from
.gitmodules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/packages/protobufs |
Removes the gitlink entry so the submodule is no longer tracked. |
.gitmodules |
Removes the protobufs submodule configuration from the repo. |
Comments suppressed due to low confidence (1)
.gitmodules:1
- After removing the only submodule entry, the repository-level
.gitmodulesis now an empty tracked file. It should be deleted from the repo entirely to avoid implying submodules still exist and to reduce confusion for tooling that scans for.gitmodules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/packages/protobufsgit submodule and cleaned up.gitmodulesTest plan