Skip to content

chore: remove protobufs git submodule#1025

Merged
danditomaso merged 1 commit intomeshtastic:mainfrom
danditomaso:remove-protobufs-submodule
Mar 11, 2026
Merged

chore: remove protobufs git submodule#1025
danditomaso merged 1 commit intomeshtastic:mainfrom
danditomaso:remove-protobufs-submodule

Conversation

@danditomaso
Copy link
Collaborator

Summary

  • Removed the packages/packages/protobufs git submodule and cleaned up .gitmodules

Test plan

  • Verify build still works without the submodule
  • Confirm no remaining references to the protobufs submodule

Copilot AI review requested due to automatic review settings March 11, 2026 00:47
@vercel
Copy link

vercel bot commented Mar 11, 2026

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository-level git submodule reference for packages/packages/protobufs, aiming to fully detach protobuf definitions from submodule management.

Changes:

  • Removed the packages/packages/protobufs submodule entry (gitlink) from the repo.
  • Removed the corresponding submodule configuration from .gitmodules.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/packages/protobufs Removes the gitlink entry so the submodule is no longer tracked.
.gitmodules Removes the protobufs submodule configuration from the repo.
Comments suppressed due to low confidence (1)

.gitmodules:1

  • After removing the only submodule entry, the repository-level .gitmodules is now an empty tracked file. It should be deleted from the repo entirely to avoid implying submodules still exist and to reduce confusion for tooling that scans for .gitmodules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danditomaso danditomaso merged commit 0579ec5 into meshtastic:main Mar 11, 2026
6 of 7 checks passed
@danditomaso danditomaso deleted the remove-protobufs-submodule branch March 11, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants