Bump Apache Arrow#2464
Conversation
WillAyd
force-pushed
the
bump-apache-arrow
branch
8 times, most recently
from
cc972ed to
d9faf7b
Compare
|
FYI @kou |
WillAyd
force-pushed
the
bump-apache-arrow
branch
from
d9faf7b to
2393d18
Compare
| license: 'Apache-2.0', | ||
| meson_version: '>=1.3.0', | ||
| default_options: ['c_std=gnu11,c11', 'warning_level=2', 'cpp_std=c++17'], | ||
| default_options: ['c_std=c11', 'warning_level=2', 'cpp_std=c++17'], |
There was a problem hiding this comment.
I'm not entirely sure why this is problematic now, but the CI reports this error:
cc: error: unrecognized command-line option ‘-std=gnu11,c11’; did you mean ‘-std=gnu++11’?
https://github.com/mesonbuild/wrapdb/actions/runs/18844109396/job/53763852587
I don't think its a huge deal to change for now; can take a closer look if it becomes a problem in future versions
There was a problem hiding this comment.
I think that we can use -std=gnu11 OR -std=c11.
There was a problem hiding this comment.
Thanks - I can't remember why we needed the gnu extensions upstream in the first place, and maybe we don't any more. Will investigate that separately from this
WillAyd
force-pushed
the
bump-apache-arrow
branch
from
2393d18 to
ade0655
Compare
WillAyd
force-pushed
the
bump-apache-arrow
branch
from
ade0655 to
5aea3c4
Compare
|
I think this is as good as we are going to get for CI with Arrow 22.0.0. Windows support is still not fully implemented upstream, and Alpine is not implemented. The macOS failure is a regression from the 21.0.0 release, but that appears to be a result of an upstream issue (see apache/arrow#47961) |
2 participants
No description provided.