Serve releases.json from GitHub Pages to fix publishing race#2527
Serve releases.json from GitHub Pages to fix publishing race#2527bgilbert merged 1 commit intomesonbuild:masterfrom
releases.json from GitHub Pages to fix publishing race#2527Conversation
|
This requires one repo setting to be changed: the Pages deployment source must be GitHub Actions. 
Making this change should automatically create a |
bgilbert
force-pushed
the
pages
branch
2 times, most recently
from
1cc1160 to
1944706
Compare
|
This PR fixes a user-visible race condition in WrapDB infrastructure, but requires a repository admin to make the configuration change described in #2527 (comment). Could an admin, e.g. @eli-schwartz, please take a look? |
|
Done for GitHub Actions. I can't update the nginx config. |
|
Yup, thanks. Will merge when I'm at a computer, confirm that it's working, and then the nginx config can be updated afterward. |
Meson fetches releases.json directly from the repo, via a redirect from wrapdb.mesonbuild.com. When a PR lands, releases.json is updated immediately but the GitHub release (with the wrap file, source mirror, and patch zip) is updated after a delay, which can be lengthy if CI is heavily loaded or down. During this time, `meson wrap install` and `meson wrap update` fail on the newly-updated wraps. Maintain a second copy of releases.json that lags the one in Git, updating it only after all the releases it describes have been published. Publish it via GitHub Pages: have create_release.py generate a static site, then publish that in the release workflow. Because of how GitHub Pages works with custom domains, the new file will be available from https://mesonbuild.com/wrapdb/releases.json. Update the wrapdb.mesonbuild.com nginx config to redirect there instead. While we're here, minify the published releases.json.
|
Deployed successfully. @tp-m, could you please sync the nginx config when you get a chance? |
|
@tp-m, ping, please sync the nginx config. |
|
Sorry, missed the pings here. Best to ping me on IRC if you don't get a quick response :) Should be deployed now. |
3 participants
Meson fetches
releases.jsondirectly from the repo, via a redirect fromwrapdb.mesonbuild.com. When a PR lands,releases.jsonis updated immediately but the GitHub release (with the wrap file, source mirror, and patch zip) is updated after a delay, which can be lengthy if CI is heavily loaded or down. During this time,meson wrap installandmeson wrap updatefail on the newly-updated wraps.Maintain a second copy of
releases.jsonthat lags the one in Git, updating it only after all the releases it describes have been published. Publish it via GitHub Pages: havecreate_release.pygenerate a static site, then publish that in the release workflow. Because of how GitHub Pages works with custom domains, the new file will be available from https://mesonbuild.com/wrapdb/releases.json. Update thewrapdb.mesonbuild.comnginx config to redirect there instead.While we're here, minify the published
releases.json.cc @tp-m