Skip to content

Clean up README.md, remove redundancies and fix code#229

Open
ganji759 wants to merge 3 commits intometa-pytorch:mainfrom
ganji759:main
Open

Clean up README.md, remove redundancies and fix code#229
ganji759 wants to merge 3 commits intometa-pytorch:mainfrom
ganji759:main

Conversation

@ganji759
Copy link
Copy Markdown

@ganji759 ganji759 commented Apr 7, 2026

Fixes made:

  1. Removed duplicate bird classifier code (was appearing twice)
  2. Fixed broken YOLO download code (added missing YOLO module and function calls)
  3. Reorganized into clear 5-step flow: Download → Convert → Deploy
  4. Fixed missing # Python comments
  5. Removed the stray "Run it from a regular terminal" text that was inside a code block

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 7, 2026
@kirklandsign
Copy link
Copy Markdown
Contributor

@claude review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Android YOLO/ExecuTorch README to remove duplicated content and present a clearer end-to-end workflow for downloading, converting, and deploying the models.

Changes:

  • Reformat README into a 5-step flow with clearer headings and code blocks.
  • Fix broken YOLO download snippets by adding the missing ultralytics.YOLO usage.
  • Clean up stray/duplicated text and improve section formatting (ADB instructions, feature lists).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Yolo/android/README.md Outdated
Comment thread Yolo/android/README.md Outdated
Comment thread Yolo/android/README.md Outdated
@kirklandsign
Copy link
Copy Markdown
Contributor

Minor nits

  • No trailing newline (\ No newline at end of file). Worth adding one back —
    consistent with the rest of the repo.
  • Trailing whitespace preserved in the first bird-classifier block (context
    lines 17–21 still have long runs of spaces). Patch didn't touch them since
    they're context; would be nice to strip in the same commit.
  • YOLO download snippets switch from python -c "..." one-liners to bare Python
    blocks. That's fine, but a one-line note like "run in a Python REPL or save
    to a file" would help since the previous form was directly executable.
  • In the Prerequisites pip install, torch + executorch is fine, but executorch
    typically pins a matching torch — worth mentioning constraints or linking to
    executorch install docs rather than letting pip resolve.

@ganji759
Copy link
Copy Markdown
Author

@kirklandsign let me revisit the changes and keep you posted.

ganji759 added 2 commits May 4, 2026 23:42
…wnload step,remove duplicate pip install ultralytics, strip trailing white space and final new line, link to executorch install docs
@ganji759
Copy link
Copy Markdown
Author

ganji759 commented May 4, 2026

Thanks for the review @kirklandsign. The updates are addressed in the latest commit.

@ganji759 ganji759 closed this May 4, 2026
@ganji759 ganji759 reopened this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants