Skip to content

chore(ci): releases#16

Closed
kristof-mattei wants to merge 1 commit intomainfrom
release-train
Closed

chore(ci): releases#16
kristof-mattei wants to merge 1 commit intomainfrom
release-train

Conversation

@kristof-mattei
Copy link
Copy Markdown
Collaborator

@kristof-mattei kristof-mattei commented Mar 6, 2026

  • Docker container is built on every PR, not published.
  • Upon accepting PR, changelog is generated + new tag.
  • New release is published with ^ changelog + tag
  • New tag kicks off Docker container build + publish for v{x}, v{x.y}, v{x.y.z} and latest

@kristof-mattei kristof-mattei requested a review from a team March 6, 2026 22:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Test results for Rust

305 tests  ±0   305 ✅ ±0   5s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7f885ae. ± Comparison against base commit 73b3442.

♻️ This comment has been updated with latest results.

@esatterwhite
Copy link
Copy Markdown

esatterwhite commented Mar 7, 2026

The binary and container should be built and released from what is on main after it has merged. We don't release from prs or branches

We don't need merge commits

Copy link
Copy Markdown

@esatterwhite esatterwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very much outside the way the company has managed releases.
We need to figure why there is such a disconnect with this repository, figure out how we can bring this closer to our current standards, and determine what from this and actually neccesary.

@kristof-mattei kristof-mattei force-pushed the release-train branch 6 times, most recently from c18342c to 7f885ae Compare March 7, 2026 19:04
@gjanco
Copy link
Copy Markdown
Collaborator

gjanco commented Mar 8, 2026

This is very much outside the way the company has managed releases. We need to figure why there is such a disconnect with this repository, figure out how we can bring this closer to our current standards, and determine what from this and actually neccesary.

We discussed this in the Innovation Meeting Thursday. There was concern that malicious code could be run in Jenkins when we accept a PR. GH Actions was brought up as a good alternative (Phil will probably be moving vector/edge there as well).

@Shearerbeard
Copy link
Copy Markdown
Collaborator

Closed - stale

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants