refactor(board): consolidate sync indicator to footer#100
Merged
mhersson merged 2 commits intoMay 18, 2026
Conversation
… duplicates
- Remove SyncIndicator component and delete SyncIndicator.tsx
- Drop connected/syncStatus/onSyncClick props from AppHeaderProps and render
- Remove lastUpdated prop and trailing span from BoardBand sub-line
- Add onSyncClick prop to BoardFooter; render sync label as <button> when
handler is provided, plain <span> otherwise
- Remove "· 1 board" suffix from footer card/column count line
- Remove pulsating green dot from board footer (drop .board-footer__pulse::before)
- Add .board-footer__sync-label CSS for the clickable sync label button
- Wire onSyncClick={triggerSync} from ProjectShell into Board into BoardFooter
- Update BoardBand and BoardFooter tests to match new prop shapes
- Show syncing / error / idle states with aria-busy and tooltip - Add useRef re-entrancy guard to triggerSync - Self-tick relative-time label every 30s in BoardFooter - Move SSE-connected dot from Sidebar to BoardFooter (visible to all) - Drop now-redundant relativeTime helper and syncLabel from ProjectShell
mhersson
deleted the
ctxmax-509/git-sync-on-3-different-places-in-the-board-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncIndicator.tsxcomponent (and its 30s relative-timesetInterval); prunes the now-unusedconnected,syncStatus,onSyncClickprops fromAppHeaderPropsand thelastUpdatedprop fromBoardBandProps. The.board-footer__pulseCSS rule and its::beforepseudo-element are gone;@keyframes pulse-dotis retained because.board-band__pulsestill consumes it.onSyncClickprop onBoardFooteris wired throughBoardtoProjectShell.triggerSync()so the consolidated footer indicator initiates a sync on click; renders as a<button>when a handler is provided, plain<span>otherwise.Test plan
cd web && npm test -- --run(49 files / 592 tests pass)cd web && npm run lint(clean)cd web && npx tsc --noEmit(clean)Stop All(when applicable),PaletteSelector, andThemeToggle— no Connected dot, no sync time… shipped this weekwith no trailingUpdated …/git sync …<sync label> <N> cards · <M> columns <rail toggle>with no· 1 boardand no pulsating dotReview notes
Automated review (Opus, 3 specialists) flagged one Important consideration as a candidate follow-up:
SyncIndicatorrendered three states (syncing,last_sync_error, idle); the consolidated footer label only surfaces the idle/last-sync-time state.syncStatus.syncingandsyncStatus.last_sync_errorare no longer read anywhere, andtriggerSyncerrors are caught and swallowed inuseSync.ts. Out of scope per the card's literal acceptance criteria but worth a follow-up if silent error/in-flight is undesirable.See the parent card's
## Review Findingssection for the full set of minor a11y/style notes.