fix(frontend): hide hamburger menu on desktop via Tailwind utilities#103
Merged
mhersson merged 2 commits intoMay 18, 2026
Merged
Conversation
added 2 commits
May 18, 2026 11:56
- Replace `apd-hamburger` class on UtilityBar button with Tailwind utilities
- Un-layered `.apd-hamburger { display: inline-flex }` in index.css overrode
Tailwind v4's `md:hidden` at all viewport sizes due to CSS Cascading Layers
- New className uses `md:hidden` + inline Tailwind utilities, matching the
AppHeader hamburger pattern where `md:hidden` works correctly
- Remove `.apd-hamburger`, `.apd-hamburger:hover`, and `.apd-hamburger:focus-visible`
from index.css — class no longer used anywhere
… affordances - Restore focus ring color to var(--aqua) per dashboard convention - Restore hover:bg-[var(--bg1)] for visible hover feedback on mobile - Add shrink-0 to prevent button compression in flex row - Update transition to cover both opacity and background-color
mhersson
deleted the
ctxmax-514/hamburger-menu-for-mobile-devices-is-showing-on-de
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UtilityBar.tsxwas always visible on all viewport sizes because.apd-hamburgerinindex.csssetdisplay: inline-flexwithout a@layerwrapper, which overrides Tailwind v4'smd:hidden(inside@layer utilities) per the CSS Cascading Layers spec..apd-hamburgercustom class from the button and replaced it with inline Tailwind utilities, matching the working pattern inAppHeader.tsx.shrink-0,hover:bg-[var(--bg1)],focus-visible:ring-[var(--aqua)],transition-[opacity,background-color]..apd-hamburger,.apd-hamburger:hover, and.apd-hamburger:focus-visibleCSS rules fromindex.css.Test plan
var(--aqua)) when button is focused via keyboard on mobile.var(--bg1)) and opacity change on mobile.AppHeaderhamburger (unrelated to this change) still works correctly at mobile width.go test ./internal/...passes.