no-pad: add toplevel -p option to disable frame padding#13
Open
no-pad: add toplevel -p option to disable frame padding#13
Conversation
igudich
reviewed
Apr 9, 2026
test/test-padding.cxx
Outdated
Comment on lines
+233
to
+235
| NoPadGuard *gp = &g; | ||
| (void)gp; // suppress unused warning | ||
| NO_PAD = 0; |
Contributor
There was a problem hiding this comment.
Can't get that. Why to use the guard at all? What does this pointer do? Some trick here?
Contributor
Author
There was a problem hiding this comment.
No this does not make any sense. The entire last part of this testcase is of little value, I will remove it. I see some general tests for padding also snuck into this patch, which was not the intention, so I will remove those as well!
This enables sending runt frames. This is useful for testing on NPI ports and frame injection where IFH is prepended, so the wire length is above 60 bytes, while the frame data may be below.
jeso-mchp
force-pushed
the
master.add-no-pad-option
branch
from
e0926f9 to
5b163e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables sending runt frames. This is useful for testing on NPI ports and frame injection where IFH is prepended, so the wire length is above 60 bytes, while the frame data may be below.