victoriametrics: support list values in args for duplicate CLI flags (e.g. multiple remoteWrite.url)#735
Open
djooberlee wants to merge 1 commit intomicrodevops-com:masterfrom
Open
victoriametrics: support list values in args for duplicate CLI flags (e.g. multiple remoteWrite.url)#735djooberlee wants to merge 1 commit intomicrodevops-com:masterfrom
djooberlee wants to merge 1 commit intomicrodevops-com:masterfrom
Conversation
…(e.g. multiple remoteWrite.url)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of VictoriaMetrics configuration arguments, especially for cases where multiple values are needed for certain command-line flags. The changes allow users to specify lists of values in the pillar configuration, which are then correctly rendered as repeated arguments in the setup. Example usage is documented in the pillar file for
vmagent.Enhancements to argument handling:
victoriametrics/_setup.slsto support lists of values, ensuring that each value is rendered as a separate command-line argument for flags that require repetition.Documentation improvements:
victoriametrics/pillar.exampleundervmagentto show how to use lists for repeated arguments, such as multipleremoteWrite.url,remoteWrite.basicAuth.username, andremoteWrite.basicAuth.passwordvalues.