Skip to content

Settings: Read defaults from the bundled partition (#2852) #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abranson wants to merge 1 commit into
base: master
Choose a base branch
from
+48 −18
Open

Settings: Read defaults from the bundled partition (#2852) #3394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 48 additions & 18 deletions play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import android.content.ContentProvider
import android.content.ContentValues
import android.content.Context
import android.content.Context.MODE_PRIVATE
import android.content.pm.ApplicationInfo
import android.content.SharedPreferences
import android.database.Cursor
import android.database.MatrixCursor
Expand Down Expand Up @@ -38,6 +39,43 @@ private const val SETTINGS_PREFIX = "org.microg.gms.settings."
* because it provides safe access from different processes which normal [SharedPreferences] don't.
*/
class SettingsProvider : ContentProvider() {
private fun getFilePreferences(path: String): SharedPreferences? {
return try {
Context::class.java.getDeclaredMethod(
"getSharedPreferences",
File::class.java,
Int::class.javaPrimitiveType
).invoke(context, File(path), MODE_PRIVATE) as SharedPreferences
} catch (ignored: Exception) {
null
}
}

private fun ApplicationInfo.invokeHiddenBooleanMethod(name: String): Boolean? {
return try {
ApplicationInfo::class.java.getMethod(name).invoke(this) as Boolean
} catch (ignored: Exception) {
null
}
}

private fun gatherDefaultPreferences(): List<SharedPreferences?> {
val applicationInfo = context?.applicationInfo ?: return emptyList()
val systemDefaultPreferences = getFilePreferences("/system/etc/microg.xml")
return when {
applicationInfo.invokeHiddenBooleanMethod("isProduct") == true ->
listOf(
getFilePreferences("/product/etc/microg.xml"),
systemDefaultPreferences
)
applicationInfo.invokeHiddenBooleanMethod("isSystemExt") == true ->
listOf(
getFilePreferences("/system_ext/etc/microg.xml"),
systemDefaultPreferences
)
else -> listOf(systemDefaultPreferences)
}
}

private val preferences: SharedPreferences by lazy {
PreferenceManager.getDefaultSharedPreferences(context)
Expand All @@ -48,16 +86,8 @@ class SettingsProvider : ContentProvider() {
private val unifiedNlpPreferences by lazy {
context!!.getSharedPreferences("unified_nlp", MODE_PRIVATE)
}
private val systemDefaultPreferences: SharedPreferences? by lazy {
try {
Context::class.java.getDeclaredMethod(
"getSharedPreferences",
File::class.java,
Int::class.javaPrimitiveType
).invoke(context, File("/system/etc/microg.xml"), MODE_PRIVATE) as SharedPreferences
} catch (ignored: Exception) {
null
}
private val packagedDefaultPreferences: List<SharedPreferences?> by lazy {
gatherDefaultPreferences()
}
private val metaDataPreferences: SharedPreferences by lazy {
MetaDataPreferences(context!!, SETTINGS_PREFIX)
Expand Down Expand Up @@ -279,7 +309,7 @@ class SettingsProvider : ContentProvider() {
DroidGuard.ENABLED -> getSettingsBoolean(key, false)
DroidGuard.MODE -> getSettingsString(key)
DroidGuard.NETWORK_SERVER_URL -> getSettingsString(key)
DroidGuard.FORCE_LOCAL_DISABLED -> systemDefaultPreferences?.getBoolean(key, false) ?: false
DroidGuard.FORCE_LOCAL_DISABLED -> packagedDefaultPreferences.getBoolean(key, false)
DroidGuard.HARDWARE_ATTESTATION_BLOCKED -> getSettingsBoolean(key, true)
else -> throw IllegalArgumentException("Unknown key: $key")
}
Expand Down Expand Up @@ -458,18 +488,18 @@ class SettingsProvider : ContentProvider() {
}

/**
* Returns the current setting of the given [key]
* using the default value from [systemDefaultPreferences] or [def] if not available.
* Returns the current setting of the given [key] using user preferences,
* packaged defaults, manifest metadata defaults, and finally [def].
* @return the current setting as [Int], because [ContentProvider] does not support [Boolean].
*/
private fun getSettingsBoolean(key: String, def: Boolean): Int {
return listOf(preferences, systemDefaultPreferences, metaDataPreferences).getBooleanAsInt(key, def)
return (listOf(preferences) + packagedDefaultPreferences + metaDataPreferences).getBooleanAsInt(key, def)
}

private fun getSettingsString(key: String, def: String? = null): String? = listOf(preferences, systemDefaultPreferences, metaDataPreferences).getString(key, def)
private fun getSettingsInt(key: String, def: Int): Int = listOf(preferences, systemDefaultPreferences, metaDataPreferences).getInt(key, def)
private fun getSettingsLong(key: String, def: Long): Long = listOf(preferences, systemDefaultPreferences, metaDataPreferences).getLong(key, def)
private fun getUnifiedNlpSettingsStringSetCompat(key: String, def: Set<String>): Set<String> = listOf(unifiedNlpPreferences, preferences, systemDefaultPreferences).getStringSetCompat(key, def)
private fun getSettingsString(key: String, def: String? = null): String? = (listOf(preferences) + packagedDefaultPreferences + metaDataPreferences).getString(key, def)
private fun getSettingsInt(key: String, def: Int): Int = (listOf(preferences) + packagedDefaultPreferences + metaDataPreferences).getInt(key, def)
private fun getSettingsLong(key: String, def: Long): Long = (listOf(preferences) + packagedDefaultPreferences + metaDataPreferences).getLong(key, def)
private fun getUnifiedNlpSettingsStringSetCompat(key: String, def: Set<String>): Set<String> = (listOf(unifiedNlpPreferences, preferences) + packagedDefaultPreferences).getStringSetCompat(key, def)

private fun SharedPreferences.getStringSetCompat(key: String, def: Set<String>): Set<String> {
if (SDK_INT >= 11) {
Expand Down