-
Notifications
You must be signed in to change notification settings - Fork 180
Refactor e2e Federated Credentials test to use a stable repository #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…repository Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…rove pagination and timestamp comparison Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…federated credentials Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
mazhelez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
@copilot the following script is used in a workflow to clean up temp repositories: "Internal\Scripts\RemoveTempRepos.ps1"
Can you adjust the script or rename the repository, so that it doesn't get deleted?
…function, exclude tmp-bingmaps from cleanup Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Done. Updated |
…ce to avoid auto-cleanup Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
mazhelez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there.
@copilot can you please also remove trailing whitespaces?
…aces Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…h repo clone Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
|
@copilot can you please resolve the merge conflicts? |
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
❔What, Why & How
The FederatedCredentials e2e test was refactored to use a stable repository (
e2e-bingmaps.appsource) instead of deleting and recreating it on each run. Federated credentials require stable repository identity to function correctly.Changes:
Added helper functions to
e2eTests/e2eTestHelper.psm1:CleanupWorkflowRuns: Deletes all workflow runs in a repository to ensure clean state for testingResetRepositoryToSource: Resets a repository to match a source repository via git reset --hard and force push, preserving repository identityModified test flow in
e2eTests/scenarios/FederatedCredentials/runtest.ps1:e2e-bingmaps.appsourcerepository to exist before running (throws error if missing)bcsamples-bingmaps.appsourcefor deterministic stateRepository naming:
tmp-bingmaps.appsourcetoe2e-bingmaps.appsourceto avoid automatic deletion by cleanup scripts (which targettmp*pattern)Fixed "unknown flag: --quiet" error:
-- --quietfrominvoke-gh repo clonecalls (gh doesn't properly handle this flag)--quiet(fetch, checkout, reset, push, commit) are unaffected and continue to work correctlyCode quality:
Before:
After:
✅ Checklist
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.