Fix case-sensitive path lookup for Performance Toolkit sample app on Linux

[Copilot]

❔What, Why & How

The hardcoded path in CreateApp.ps1 uses backslashes and a fixed directory casing, which doesn't resolve correctly on Linux's case-sensitive filesystem when creating performance test apps.

Replace the hardcoded Join-Path with a recursive file search that first narrows scope to the Applications subdirectory:

# Before (fails on Linux)
$sampleApp = Join-Path $folders[1] "Applications\testframework\performancetoolkit\Microsoft_Performance Toolkit Samples.app"

# After (cross-platform, avoids hardcoded directory casing)
$searchRoot = Get-ChildItem -Path $folders[1] -Directory -ErrorAction SilentlyContinue | Where-Object { $_.Name -ieq 'Applications' } | Select-Object -First 1 -ExpandProperty FullName
if (!$searchRoot) { $searchRoot = $folders[1] }
$sampleApp = Get-ChildItem -Path $searchRoot -Filter "Microsoft_Performance Toolkit Samples.app" -File -Recurse -ErrorAction SilentlyContinue | Select-Object -First 1 -ExpandProperty FullName

Additional improvements:

• Added a null check on $sampleApp before Test-Path since Get-ChildItem can return nothing.
• Added -File flag to restrict results to files only.
• Added -ErrorAction SilentlyContinue to prevent transient access errors from failing the action under $ErrorActionPreference = 'Stop'.
• Narrowed the recursive search to the Applications subdirectory (found case-insensitively via -ieq) to reduce IO, falling back to the full artifact root if not found.
• Improved the error message to include the searched root path and expected filename for easier CI debugging.
• Consolidated duplicate tests into a single parameterized test using Pester -TestCases.

✅ Checklist

• Add tests (E2E, unit tests)
• Update RELEASENOTES.md
• Update documentation (e.g. for new settings or scenarios)
• Add telemetry

[mazhelez]

@copilot nice work! Please include release notes.

[Copilot]

@copilot nice work! Please include release notes.

Added in 58e10fb.

[mazhelez]

By the way, @copilot, I don't think the casing has change (as you claim in the PR description).
I believe the issue is that the action run on linux and there the paths are treated differently than in windows.

Can you verify the tests run in both windows and linux?

[Copilot]

By the way, @copilot, I don't think the casing has change (as you claim in the PR description).
I believe the issue is that the action run on linux and there the paths are treated dif...

You're right — the artifact directory casing itself hasn't changed between BC versions. The real issue is that the hardcoded path with backslashes doesn't resolve correctly on Linux's case-sensitive filesystem. I'll update the PR description to reflect that.

Regarding cross-platform testing: the CI matrix in .github/workflows/CI.yaml runs all tests under Tests/ on both windows-latest (PS5) and ubuntu-latest (PS7), so the CreateApp.Action.Test.ps1 tests are verified on both platforms. I confirmed all 4 tests pass on Linux locally as well.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes Linux failures when creating Performance Toolkit performance test apps by avoiding hardcoded, case-sensitive directory paths in CreateApp.ps1.

Changes:

• Replace hardcoded Join-Path sample-app lookup with a recursive Get-ChildItem search.
• Add a null/empty guard before calling Test-Path on the discovered sample-app path.
• Add Pester tests covering mixed/legacy directory casing, and update release notes for Issue 2265.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
Actions/CreateApp/CreateApp.ps1	Switches to recursive discovery of the sample app and guards against missing results on Linux.
Tests/CreateApp.Action.Test.ps1	Adds tests to validate sample-app discovery across directory casing variations.
RELEASENOTES.md	Documents the Linux fix under Issue 2265.

[mazhelez]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied all review comments in 90741e8:

• Added -File and -ErrorAction SilentlyContinue to Get-ChildItem for robustness
• Improved the error message to include the searched root path and filename
• Consolidated the two duplicate tests into a single parameterized test using -TestCases

[ChrisBlankDe]

Its not ideal to search through the entire tree, but I can't think of a better solution either.
Hard-coding the two path formats and checking both wouldn't be ideal either, and it wouldn't be future-proof.

lgtm.

[mazhelez]

Its not ideal to search through the entire tree, but I can't think of a better solution either. Hard-coding the two path formats and checking both wouldn't be ideal either, and it wouldn't be future-proof.

lgtm.

I agree. @copilot can you please address this comment

[Copilot]

Its not ideal to search through the entire tree, but I can't think of a better solution either. Hard-coding the two path formats and checking both wouldn't be ideal either, and it wouldn't be future...

Narrowed the search scope in dedf5ba — the recursive search now first looks for an Applications subdirectory (case-insensitively via -ieq) and only searches within that. Falls back to the full artifact root if no Applications directory is found. Also cleaned up to use -ieq for idiomatic PowerShell in 5673cc1.