Skip to content

Fix AG_E_LAYOUT_CYCLE crash in widgets due to MinHeight exceeding Max Height #9340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranav-gupta-msft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix AG_E_LAYOUT_CYCLE crash in widgets due to MinHeight exceeding Max Height #9340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions source/uwp/SharedRenderer/lib/AdaptiveCarouselRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,21 @@ namespace winrt::AdaptiveCards::Rendering::Xaml_Rendering::implementation
}

uint32_t carouselMinHeight = styledCollection.MinHeight();
auto fixedHeightInPixel = carousel.HeightInPixels();

// Ensure MinHeight doesn't exceed fixed height to prevent AG_E_LAYOUT_CYCLE
if (carouselMinHeight > 0)
{
gridContainer.MinHeight(carouselMinHeight);
if (fixedHeightInPixel && carouselMinHeight > fixedHeightInPixel)
{
gridContainer.MinHeight(static_cast<double>(fixedHeightInPixel));
}
else
{
gridContainer.MinHeight(carouselMinHeight);
}
}

auto fixedHeightInPixel = carousel.HeightInPixels();
if (fixedHeightInPixel)
{
carouselUI.MaxHeight(static_cast<double>(fixedHeightInPixel));
Expand Down
11 changes: 10 additions & 1 deletion source/uwp/SharedRenderer/lib/XamlBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,16 @@ namespace AdaptiveCards::Rendering::Xaml_Rendering

if (cardMinHeight > 0)
{
rootAsFrameworkElement.MinHeight(cardMinHeight);
// If fixed dimensions are set, ensure MinHeight doesn't exceed MaxHeight to prevent AG_E_LAYOUT_CYCLE
if (xamlBuilder && xamlBuilder->m_fixedDimensions && cardMinHeight > xamlBuilder->m_fixedHeight)
{
// Clamp MinHeight to not exceed the fixed height constraint
rootAsFrameworkElement.MinHeight(xamlBuilder->m_fixedHeight);
}
else
{
rootAsFrameworkElement.MinHeight(cardMinHeight);
}
}

auto selectAction = adaptiveCard.SelectAction();
Expand Down
Loading