[Beta] Merge Common into Core #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request merges the @microsoft/applicationinsights-common package into @microsoft/applicationinsights-core-js as part of preparing for alignment with the OTel-SDK branch. This consolidation simplifies the dependency tree and improves tree-shaking capabilities.
Changes:
- Merged all Common package source code into Core under
src/Common/directory - Created a compatibility layer in the Common package that re-exports from Core for backward compatibility
- Updated all internal imports in Common source files to reference Core's JavaScriptSDK modules
- Updated test files and moved Common tests into Core's test suite
- Added comprehensive documentation including migration guide and updated READMEs
Reviewed changes
Copilot reviewed 54 out of 114 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/AppInsightsCore/tsconfig.json | Added Common source directories to TypeScript compilation |
| shared/AppInsightsCore/src/applicationinsights-core-js.ts | Added comprehensive exports for all Common package functionality |
| shared/AppInsightsCore/src/OpenTelemetry/**/*.ts | Minor whitespace/formatting fixes (removed double semicolons, trailing spaces) |
| shared/AppInsightsCore/src/Common/**/*.ts | All Common source files moved to Core with updated import paths |
| shared/AppInsightsCore/Tests/Unit/src/**/*.ts | Updated test imports and added Common tests to Core test suite |
| shared/AppInsightsCore/README.md | Added deprecation notice and migration information |
| shared/AppInsightsCommon/src/applicationinsights-common.ts | Replaced with compatibility layer that re-exports from Core |
| shared/AppInsightsCommon/package.json | Disabled test scripts (tests now run in Core) |
| shared/AppInsightsCommon/Tests/** | Removed test files and configurations |
| shared/AppInsightsCommon/README.md | Added deprecation warning with migration instructions |
| docs/upgrade/MergeCommonToCore.md | Comprehensive migration guide for users |
| RELEASES.md | Documented the merge with timeline for deprecation |
| gruntfile.js | Disabled Common package test tasks |
| .aiAutoMinify.json | Moved const enums from Common to Core configuration |
| channels/applicationinsights-channel-js/** | Updated imports to reference Core instead of Common |
| AISKU/Tests/**/*.ts | Updated imports to reference Core instead of Common |
… into Core - Update imports in Common telemetry files to use relative paths instead of external package references - Add comprehensive exports from applicationinsights-core-js.ts for all Common module functionality including telemetry classes, interfaces, enums, helper functions, contracts, and plugin identifiers
MSNev
force-pushed
the
MSNev/MergeCommon
branch
from
f5ac5ff to
e60c0ce
Compare
MSNev
force-pushed
the
MSNev/MergeCommon
branch
from
a1d181e to
26b8d7b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MSNev
force-pushed
the
MSNev/MergeCommon
branch
3 times, most recently
from
54681c6 to
ba5e3c5
Compare
Phase 3: Add/Adjust tree-shaking hints and reduce duplication from the merge Phase 4: Stop using applicationinsights-common (missed by Co-Pilot)
MSNev
force-pushed
the
MSNev/MergeCommon
branch
from
ba5e3c5 to
7054b1b
Compare
rads-1996
reviewed
Feb 2, 2026
| @@ -0,0 +1,1438 @@ | |||
| # Move Layout Plan: AppInsightsCore → otel-core Structure | |||
|
|
|||
rads-1996
reviewed
Feb 2, 2026
| @@ -0,0 +1,2160 @@ | |||
| # AppInsightsCommon → AppInsightsCore Merge Plan | |||
JacksonWeber
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of preparing for merging changes between OTel-SDK branch and Beta merging Common into Core.
Next Steps: restructuring the folder structure for Core to align with the OTel-SDK
otel-core-jsproject