This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Enhance error handling and update URLs in JSON files#57
Merged
gloridelmorales merged 2 commits intomainfrom May 8, 2025
Merged
Enhance error handling and update URLs in JSON files#57gloridelmorales merged 2 commits intomainfrom
gloridelmorales merged 2 commits intomainfrom
Conversation
- Improved error messages in ProjectService.cs to include board type context. - Added a check for default repository deletion based on existing repositories. - Updated Azure DevOps URLs in multiple JSON files to the new format. - Cleaned up descriptions in TemplateSetting.json by removing HTML tags and rephrasing for clarity. - Refined error handling in Repository.cs to include timestamps and method context. - Enhanced response handling in BoardColumn.cs for better robustness.
- Simplified `HandleNewProjectCreation` by removing the `confirmedExtension` output parameter and directly assigning the result of `ValidateExtensions`. - Updated `TryGetTemplateDetails` to streamline template folder checks and improve error messaging. - Introduced a new `Parameters` dictionary in `ProjectService.cs` for better organization of user input values. - Added `GetServiceEndPointCredentials` method to prompt for user credentials based on the selected template, with error handling. - Updated placeholder replacement logic in `jsonCreateService` to utilize the new `Parameters` dictionary. - Changed `versionSpec` in `Octopus.json` from `"3.*"` to `"4.*"` to reflect the updated task versioning.
This was referenced May 7, 2025
Contributor
|
This pull request introduces several updates to the Refactoring and Code Simplification:
New Functionality:
Error Message Improvements:
Template URL Updates:
Repository Handling:
These changes improve code maintainability, enhance user experience, and ensure consistency across templates. |
gloridelmorales
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
ADOGeneratorproject, focusing on improving error messages, updating repository handling, and refining templates for Azure DevOps configurations. The changes enhance clarity in error reporting, ensure proper repository management, and align templates with updated naming conventions and URLs.Error Message Enhancements:
UpdateBoardColumn,UpdateCardFields, andUpdateCardStylesto include theboardTypefor better context when debugging issues. (src/ADOGenerator/Services/ProjectService.cs) [1] [2] [3]Repository Management Improvements:
ImportSourceCodeto create a default repository if none exists and to set theisDefaultRepoTodeteleflag accordingly. (src/ADOGenerator/Services/ProjectService.cs) [1] [2]Template Updates:
dev.azure.cominstead ofvstsdemodata.visualstudio.com). This affects templates forDL-AKS,DL-Ansible,DL-AzureFunctions, andDL-DeploymentGroups. [1] [2] [3] [4] [5] [6] [7] [8] [9]Board and Workflow Refinements:
BoardColumns.jsonto better align with Agile practices (e.g., "Active" renamed to "In Progress", "Closed" renamed to "Done"). (src/ADOGenerator/Templates/DL-DeploymentGroups/Teams/Deployment Group Team/BoardColumns.json) [1] [2]BoardRows.json,CardFields.json, andCardStyles.json, to reflect updated terminology. [1] [2] [3] [4]Bug Behavior Update:
bugsBehaviorinTeamSetting.jsonto treat bugs as requirements instead of tasks, aligning with updated project management practices. (src/ADOGenerator/Templates/DL-DeploymentGroups/Teams/Deployment Group Team/TeamSetting.json)