-
Notifications
You must be signed in to change notification settings - Fork 174
Replace deprecated --username flag with --client-id in az login --identity commands #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… commands Co-authored-by: marrobi <17089773+marrobi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Azure CLI authentication commands across Porter bundles to use the correct --client-id flag instead of the deprecated --username flag when authenticating with managed identities.
Changes:
- Updated
az login --identitycommands to use--client-idinstead of deprecated--usernameflag in 8 Porter bundles - Incremented bundle versions by a PATCH level following semantic versioning guidelines
- Updated CHANGELOG.md to document the bug fix
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/shared_services/airlock_notifier/porter.yaml | Replaced username: with client-id: in install and upgrade actions; bumped version to 1.0.10 |
| templates/shared_services/certs/porter.yaml | Replaced username: with client-id: in install and renew actions; bumped version to 0.7.9 |
| templates/shared_services/cyclecloud/porter.yaml | Replaced username: with client-id: in start and stop actions; bumped version to 0.7.4 |
| templates/workspace_services/ohdsi/porter.yaml | Replaced username: with client-id: in install and upgrade actions; bumped version to 0.3.5 |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/porter.yaml | Replaced username: with client-id: in start, stop, and reset_password actions; bumped version to 0.3.5 |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-import-reviewvm/porter.yaml | Replaced username: with client-id: in start, stop, and reset_password actions; bumped version to 0.4.4 |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/porter.yaml | Replaced username: with client-id: in start, stop, and reset_password actions; bumped version to 1.4.3 |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml | Replaced username: with client-id: in start, stop, and reset_password actions; bumped version to 1.4.4 |
| CHANGELOG.md | Added entry in BUG FIXES section documenting the deprecation fix |
Co-authored-by: marrobi <17089773+marrobi@users.noreply.github.com>
|
/test-extended |
|
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
|
/test-extended e8ed9b5 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/21170719648 (with refid (in response to this comment from @marrobi) |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 8a26ebe. ♻️ This comment has been updated with latest results. |
|
/test-extended 8a26ebe |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/21213006566 (with refid (in response to this comment from @marrobi) |
JC-wk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/test-force-approve Tests failing for another reason and this wasn't picked up as wasn't covered by tests. |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 8a26ebe) (in response to this comment from @marrobi) |
What is being addressed
Azure CLI deprecated the
--usernameflag when usingaz login --identityfor managed identity authentication. The correct flag is--client-id.How is this addressed
username:withclient-id:in allaz login --identitycommands across 8 Porter bundles:Before:
After:
Note: Shell scripts using
az login --service-principal --usernamewere not changed as--usernameremains valid for service principal authentication.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.