Fix VAT Posting Setup for invoice rounding in PEPPOL tests #6355
+2,187
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix testtype
#6311) The PEPPOL BIS Billing test's `Initialize()` method called `CompanyInfo.Get()` without ensuring the record exists, causing test failures in clean database scenarios. ## Changes Added existence check before accessing Company Information record: ```al // Before CompanyInfo.Get(); // After if not CompanyInfo.Get() then begin CompanyInfo.Init(); CompanyInfo.Insert(); end; ``` This follows standard AL pattern for setup records and ensures tests run regardless of initial database state. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Pull Request: #6267 > > There is an issue currently in they no company information record exist. > > In the initialise method in the test, ensure it exists, and set some default values. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Removed multiple test folder entries and added a specific test folder for PEPPOL.
…te/magnushar/morepeppol
Merged
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add PEPPOL tests
Fix VAT Posting Setup for invoice rounding in PEPPOL tests
Jan 28, 2026
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoice rounding tests were failing because posting creates G/L Account lines with blank VAT Product Posting Group, but no VAT Posting Setup existed for that combination (e.g.,
'DOMESTIC'+'').Changes
ConfigureVATPostingSetup()to create VAT Posting Setups with blank VAT Product Posting Group for all VAT Business Posting GroupsTests Fixed
ExportXml_SalesInvoiceLCY_InvRounding_PositiveExportXml_SalesInvoiceLCY_InvRounding_NegativeExportXml_SalesInvoiceLCY_InvRounding_NegativeTwoDiffVATExportXml_SalesCrMemoLCY_InvRounding_PositiveExportXml_ServiceInvoiceLCY_InvRounding_Positive💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.