Skip to content

Fix e-document draft UX: show error factbox and allow finalize from Ready for Draft state #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+56 −2
Draft

Fix e-document draft UX: show error factbox and allow finalize from Ready for Draft state #6365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a57ed2f
Initial plan
Copilot Jan 29, 2026
a980e9e
Fix e-document draft UX: show error factbox and allow finalize from R…
Copilot Jan 29, 2026
0320e15
Add status check after Prepare draft step before proceeding to Finish…
Copilot Jan 29, 2026
631e3e9
Remove extra reprocessing logic and add test for finalize from Ready …
Copilot Jan 29, 2026
33422be
Merge branch 'main' of https://github.com/microsoft/BCApps into copil…
Jan 30, 2026
c25a962
fix test
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Apps/W1/EDocument/App/src/Processing/Import/Purchase/EDocumentPurchaseDraft.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ page 6181 "E-Document Purchase Draft"
}
part(ErrorMessagesFactBox; "Error Messages Part")
{
Visible = false;
Visible = HasErrorsOrWarnings;
ShowFilter = false;
UpdatePropagation = Both;
}
Expand Down Expand Up @@ -524,7 +524,7 @@ page 6181 "E-Document Purchase Draft"
SetPageCaption();

Rec.CalcFields("Import Processing Status");
ShowFinalizeDraftAction := Rec."Import Processing Status" = Enum::"Import E-Doc. Proc. Status"::"Draft Ready";
ShowFinalizeDraftAction := Rec."Import Processing Status" in [Enum::"Import E-Doc. Proc. Status"::"Ready for draft", Enum::"Import E-Doc. Proc. Status"::"Draft Ready"];
ShowAnalyzeDocumentAction :=
(Rec."Import Processing Status" = Enum::"Import E-Document Steps"::"Structure received data") and
(Rec.Status = Enum::"E-Document Status"::Error);
Expand Down
54 changes: 54 additions & 0 deletions src/Apps/W1/EDocument/Test/src/Processing/EDocProcessTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,60 @@ codeunit 139883 "E-Doc Process Test"
Assert.RecordIsEmpty(PurchaseHeader);
end;

[Test]
procedure FinishDraftFromReadyForDraftStateSucceeds()
var
EDocument: Record "E-Document";
EDocImportParameters: Record "E-Doc. Import Parameters";
PurchaseHeader: Record "Purchase Header";
EDocLogRecord: Record "E-Document Log";
EDocumentPurchaseHeader: Record "E-Document Purchase Header";
EDocumentPurchaseLine: Record "E-Document Purchase Line";
EDocImport: Codeunit "E-Doc. Import";
EDocumentLog: Codeunit "E-Document Log";
EDocumentProcessing: Codeunit "E-Document Processing";
begin
// [SCENARIO] When finalize action is invoked from Ready for draft state, the system should automatically run Prepare draft first and then Finish draft
Initialize(Enum::"Service Integration"::"Mock");
LibraryEDoc.CreateInboundEDocument(EDocument, EDocumentService);
EDocument."Document Type" := "E-Document Type"::"Purchase Invoice";
EDocument.Modify();
EDocumentService."Import Process" := "E-Document Import Process"::"Version 2.0";
EDocumentService.Modify();

EDocumentPurchaseHeader."E-Document Entry No." := EDocument."Entry No";
EDocumentPurchaseHeader."Vendor VAT Id" := Vendor."VAT Registration No.";
EDocumentPurchaseHeader.Insert();
EDocumentPurchaseLine."E-Document Entry No." := EDocument."Entry No";
EDocumentPurchaseLine."Product Code" := '1234';
EDocumentPurchaseLine.Description := 'Test description';
EDocumentPurchaseLine.Insert();

EDocumentLog.SetBlob('Test', Enum::"E-Doc. File Format"::XML, 'Data');
EDocumentLog.SetFields(EDocument, EDocumentService);
EDocLogRecord := EDocumentLog.InsertLog(Enum::"E-Document Service Status"::Imported, Enum::"Import E-Doc. Proc. Status"::Readable);

EDocument."Structured Data Entry No." := EDocLogRecord."E-Doc. Data Storage Entry No.";
EDocument.Modify();

// [GIVEN] E-Document is in Ready for draft state
EDocumentProcessing.ModifyEDocumentProcessingStatus(EDocument, "Import E-Doc. Proc. Status"::"Ready for draft");
EDocument.CalcFields("Import Processing Status");
Assert.AreEqual(Enum::"Import E-Doc. Proc. Status"::"Ready for draft", EDocument."Import Processing Status", 'The status should be Ready for draft before processing.');

// [WHEN] Finish draft step is executed (simulating finalize action)
EDocImportParameters."Step to Run" := "Import E-Document Steps"::"Finish draft";
EDocImportParameters."Processing Customizations" := "E-Doc. Proc. Customizations"::"Mock Create Purchase Invoice";
EDocImport.ProcessIncomingEDocument(EDocument, EDocImportParameters);

// [THEN] The document is processed (the system ran Prepare draft automatically and then Finish draft)
EDocument.CalcFields("Import Processing Status");
Assert.AreEqual(Enum::"Import E-Doc. Proc. Status"::Processed, EDocument."Import Processing Status", 'The status should be Processed after finalize action from Ready for draft state.');

PurchaseHeader.SetRange("E-Document Link", EDocument.SystemId);
Assert.IsTrue(PurchaseHeader.FindFirst(), 'The purchase header should be created.');
end;

#region HistoricalMatchingTest

[Test]
Expand Down
Loading