Add Service Participants support for Company Information #6372

Copilot · 2026-01-29T15:09:30Z

Add Service Participants to Company Information

This PR enables Belgian companies using Peppol to configure Service Participants on Company Information, so that incoming eDocuments using Peppol Scheme 0208 (Enterprise Number) are correctly matched and received.

Changes Made

1. Extend E-Document Source Type Enum
- Added "Company" value (value 3) to enum 6123 "E-Document Source Type"
2. Add Page Extension for Company Information
- Created page extension 6165 for Company Information page
- Added "E-Document Service Participation" field similar to Customer/Vendor extensions
- Field shows count of Service Participants and drills down to the list
- Uses empty string ('') as Participant code since Company Information is a singleton
3. Update Matching Logic (Backward Compatible)
- Added new overload ValidateReceivingCompanyInfo(EDocument, EDocService) that checks Service Participants first
- Preserved original ValidateReceivingCompanyInfo(EDocument) signature for backward compatibility
- New overload calls the original method after Service Participant check
- MatchCompanyByServiceParticipant takes EDocService record parameter
- Updated call site in EDocImport to pass EDocService record
- Priority order: Service Participant → VAT Reg No. → GLN → Name/Address
4. Add Tests
- Added ValidateReceivingCompanyInfoWithMatchingServiceParticipant test: Verifies validation succeeds when a matching Company Service Participant exists
- Added ValidateReceivingCompanyInfoFallsBackToVATWhenNoServiceParticipant test: Verifies fallback to VAT/GLN matching when no Service Participant matches
5. Fix Build Warnings/Errors
- Fixed AA0175: Use IsEmpty() instead of FindFirst() when only checking record existence
- Fixed AL0118: Added missing using Microsoft.eServices.EDocument.Integration; for Service Integration enum

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

github-actions · 2026-01-29T15:34:06Z

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

Groenbech96 · 2026-01-29T15:35:51Z

@copilot Create a overload method that takes the service as argument and provides it on the table. Dont remove the filter after as well.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-01-29T15:37:35Z

@copilot Create a overload method that takes the service as argument and provides it on the table. Dont remove the filter after as well.

Done in 0e3a699. Created an overload MatchCompanyByServiceParticipant(EDocument, ServiceCode) that takes the service code as argument and removed the filter clearing logic.

Groenbech96 · 2026-01-29T15:39:00Z

@copilot dont use EDocument.GetEDocumentService().Code)).

At the call site of check receiving company info, there is a known service. Use that one.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-01-29T15:41:03Z

@copilot dont use EDocument.GetEDocumentService().Code)).

At the call site of check receiving company info, there is a known service. Use that one.

Done in 3bb73af. Updated ValidateReceivingCompanyInfo to accept ServiceCode parameter and updated the call site in EDocImport.Codeunit.al to pass EDocService.Code directly. Removed the overload that was using GetEDocumentService().Code.

Groenbech96 · 2026-01-29T15:46:08Z

src/Apps/W1/EDocument/App/src/Processing/EDocImport.Codeunit.al


            if EDocService."Validate Receiving Company" then
-                EDocImportHelper.ValidateReceivingCompanyInfo(EDocument);
+                EDocImportHelper.ValidateReceivingCompanyInfo(EDocument, EDocService.Code);


@copilot Pass the record, not a code.

Done in 9b0657f. Now passes the EDocService record instead of EDocService.Code.

Groenbech96 · 2026-01-29T15:46:53Z

src/Apps/W1/EDocument/App/src/Helpers/EDocumentImportHelper.Codeunit.al

    /// <param name="EDocument">The E-Document record.</param>
-    procedure ValidateReceivingCompanyInfo(EDocument: Record "E-Document")
+    /// <param name="ServiceCode">The E-Document Service code to match against.</param>
+    procedure ValidateReceivingCompanyInfo(EDocument: Record "E-Document"; ServiceCode: Code[20])


@copilot This is breaking. Please add an overload. Then call this original and do the new stuff before.

Done in 9b0657f. Added backward-compatible overload ValidateReceivingCompanyInfo(EDocument, EDocService) that first checks Service Participants, then calls the original ValidateReceivingCompanyInfo(EDocument) method.

…ss record not code Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Groenbech96 · 2026-01-29T16:32:27Z

@copilot Make sure you add tests.

…ngCompanyInfo Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-01-29T16:34:45Z

@copilot Make sure you add tests.

Done in d7d4ce4. Added two tests in EDocHelperTest.Codeunit.al:

ValidateReceivingCompanyInfoWithMatchingServiceParticipant: Verifies that validation succeeds when a matching Company Service Participant exists
ValidateReceivingCompanyInfoFallsBackToVATWhenNoServiceParticipant: Verifies fallback to VAT/GLN matching when no Service Participant matches

Groenbech96

Build: ./src/Apps/W1/EDocument/App/src/Helpers/EDocumentImportHelper.Codeunit.al#L315
AA0175 Variable 'ServiceParticipant' queries the database in 'MatchCompanyByServiceParticipant' but does not use the queried record. Only find or get record if you need to access the values. Consider using ISEMPTY.

…ence Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-01-29T19:21:40Z

Build: ./src/Apps/W1/EDocument/App/src/Helpers/EDocumentImportHelper.Codeunit.al#L315
AA0175 Variable 'ServiceParticipant...

Fixed in 2774d26. Changed FindFirst() to not IsEmpty() since we only need to check if a matching record exists.

Groenbech96 · 2026-01-29T20:33:49Z

@copilot Take a look at the new instructions

Copilot · 2026-01-29T20:34:44Z

@copilot Take a look at the new instructions

Could you clarify what new instructions you're referring to? I don't see any additional instructions in the comments.

Groenbech96 · 2026-01-30T09:01:00Z

@copilot revert my latest commit.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-01-30T09:02:44Z

@copilot revert my latest commit.

Done in 7d5b8fa. Reverted the AGENTS.md commit.

Groenbech96 · 2026-02-02T07:48:56Z

@copilot

Build: ./src/Apps/W1/EDocument/Test/src/Receive/EDocHelperTest.Codeunit.al#L119AL0118 The name '"Service Integration"' does not exist in the current context. -- Build: ./src/Apps/W1/EDocument/Test/src/Receive/EDocHelperTest.Codeunit.al#L76AL0118 The name '"Service Integration"' does not exist in the current context. [Build: ./src/Apps/W1/EDocument/Test/src/Receive/EDocHelperTest.Codeunit.al#L119](https://github.com//pull/6372/files#annotation_44933495907) AL0118 The name '"Service Integration"' does not exist in the current context. [Build: ./src/Apps/W1/EDocument/Test/src/Receive/EDocHelperTest.Codeunit.al#L76](https://github.com//pull/6372/files#annotation_44933495917) AL0118 The name '"Service Integration"' does not exist in the current context.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot · 2026-02-02T07:50:41Z

@copilot

...

Fixed in 33dda72. Added missing using Microsoft.eServices.EDocument.Integration; statement to resolve the Service Integration enum reference.

Initial plan

22b9c35

Copilot AI assigned Copilot and Groenbech96 Jan 29, 2026

Copilot started work on behalf of Groenbech96 January 29, 2026 15:09 View session

Add Service Participants support for Company Information

8c56da2

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add service participants configuration for company information~~ Add Service Participants support for Company Information Jan 29, 2026

Copilot AI requested a review from Groenbech96 January 29, 2026 15:19

Copilot finished work on behalf of Groenbech96 January 29, 2026 15:19

github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Jan 29, 2026

Copilot started work on behalf of Groenbech96 January 29, 2026 15:36 View session

Add overload method with service argument, remove filter clearing

0e3a699

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot finished work on behalf of Groenbech96 January 29, 2026 15:38

Copilot started work on behalf of Groenbech96 January 29, 2026 15:39 View session

Pass ServiceCode from call site instead of using GetEDocumentService()

3bb73af

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot finished work on behalf of Groenbech96 January 29, 2026 15:41

Groenbech96 requested changes Jan 29, 2026

View reviewed changes

Copilot started work on behalf of Groenbech96 January 29, 2026 15:47 View session

Add backward-compatible overload for ValidateReceivingCompanyInfo, pa…

9b0657f

…ss record not code Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot AI requested a review from Groenbech96 January 29, 2026 15:50

Copilot finished work on behalf of Groenbech96 January 29, 2026 15:50

Groenbech96 approved these changes Jan 29, 2026

View reviewed changes

Groenbech96 marked this pull request as ready for review January 29, 2026 16:31

Groenbech96 requested a review from a team as a code owner January 29, 2026 16:31

Copilot started work on behalf of Groenbech96 January 29, 2026 16:32 View session

Add tests for Company Service Participant matching in ValidateReceivi…

d7d4ce4

…ngCompanyInfo Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot AI requested a review from Groenbech96 January 29, 2026 16:35

Copilot finished work on behalf of Groenbech96 January 29, 2026 16:35

Groenbech96 approved these changes Jan 29, 2026

View reviewed changes

Groenbech96 requested changes Jan 29, 2026

View reviewed changes

Copilot started work on behalf of Groenbech96 January 29, 2026 19:20 View session

Fix AA0175: Use IsEmpty instead of FindFirst when only checking exist…

2774d26

…ence Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot finished work on behalf of Groenbech96 January 29, 2026 19:22

Copilot AI requested a review from Groenbech96 January 29, 2026 19:22

Attempt 1

d8bb261

Groenbech96 requested a review from a team as a code owner January 29, 2026 20:33

Copilot started work on behalf of Groenbech96 January 29, 2026 20:34 View session

Copilot finished work on behalf of Groenbech96 January 29, 2026 20:35

Copilot started work on behalf of Groenbech96 January 29, 2026 20:35 View session

Copilot finished work on behalf of Groenbech96 January 29, 2026 20:37

Copilot started work on behalf of Groenbech96 January 30, 2026 09:01 View session

Revert AGENTS.md commit as requested

7d5b8fa

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot finished work on behalf of Groenbech96 January 30, 2026 09:03

Copilot started work on behalf of Groenbech96 February 2, 2026 07:49 View session

Fix AL0118: Add missing using statement for Service Integration enum

33dda72

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>

Copilot finished work on behalf of Groenbech96 February 2, 2026 07:51

Add Service Participants support for Company Information #6372

Are you sure you want to change the base?

Add Service Participants support for Company Information #6372

Conversation

Copilot AI commented Jan 29, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Service Participants to Company Information

Changes Made

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Groenbech96 commented Jan 29, 2026

Uh oh!

Copilot AI commented Jan 29, 2026

Uh oh!

Groenbech96 commented Jan 29, 2026

Uh oh!

Copilot AI commented Jan 29, 2026

Uh oh!

Groenbech96 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Groenbech96 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Groenbech96 commented Jan 29, 2026

Uh oh!

Copilot AI commented Jan 29, 2026

Uh oh!

Groenbech96 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 29, 2026

Uh oh!

Groenbech96 commented Jan 29, 2026

Uh oh!

Copilot AI commented Jan 29, 2026

Uh oh!

Groenbech96 commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Groenbech96 commented Feb 2, 2026

Uh oh!

Copilot AI commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 29, 2026 •

edited by github-actions bot

Loading