[AI SDK] Surface billing setup errors and handle default AOAI policy for self managed resources #6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for self managed resources
encimita
approved these changes
Jan 30, 2026
msft-sam
approved these changes
Jan 30, 2026
src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al
Show resolved
Hide resolved
darjoo
reviewed
Feb 2, 2026
|
|
||
| AzureOpenAIPolicy := AOAIChatCompletionParams.GetAOAIPolicyParams().GetAOAIPolicy(); | ||
| AOAIPolicyParams := AOAIChatCompletionParams.GetAOAIPolicyParams(); | ||
| AzureOpenAIPolicy := (ChatCompletionsAOAIAuthorization.GetResourceUtilization() = Enum::"AOAI Resource Utilization"::"Self-Managed") and AOAIPolicyParams.IsDefaultPolicy() |
Contributor
There was a problem hiding this comment.
I'd refactor this. I understand we added inline if/else but it also makes it harder to read and isn't a pattern for us.
policy = AOAIPolicyParams.GetAOAIPolicy()
if default + self-managed then
policy = ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue 1:
We don't surface billing setup issues because an Error is raised within the try function and the operation result is never sent on the response codeunit passed by var. So the error message is never surfaced. Changing the SendRequest to return the error first.
Issue 2:
AOAI policies would default to ConveservativeWithXpia which generally does not exist for self managed resources since that's something dedicated in our copilot service. Changing the SendChatCompletionRequest logic to not pass any XPIA policy for self managed resources if the policy are still the default one.
Work Item(s)
Fixes AB#620032, AB#615189