Skip to content

[Shopify] Test failure in UnitTestUpdateTaxRegistrationIdForVATRegistrationNo for Belgian customers #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbuyuka wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

[Shopify] Test failure in UnitTestUpdateTaxRegistrationIdForVATRegistrationNo for Belgian customers #6400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Apps/W1/Shopify/Test/Companies/ShpfyTaxIdMappingTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ codeunit 134246 "Shpfy Tax Id Mapping Test"
NewTaxRegistrationId := LibraryERM.GenerateVATRegistrationNo(CompanyInformation."Country/Region Code");
// [GIVEN] Customer with empty VAT Registration No.
CreateCustomerWithVATRegNo(Customer, '');
Copy link
Contributor

@haoranpb haoranpb Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we then losing code coverage here in BE?

Consider moving the code into CreateCustomerWithVATRegNo

if CompanyInformation."Country/Region Code" = 'BE' then begin
Customer."Country/Region Code" := 'DE'; // VAT Reg No. not allowed for BE Customers
Customer.Modify();
NewTaxRegistrationId := LibraryERM.GenerateVATRegistrationNo(Customer."Country/Region Code");
end;
// [GIVEN] TaxRegistrationIdMapping interface is "VAT Registration No."
TaxRegistrationIdMapping := Enum::"Shpfy Comp. Tax Id Mapping"::"VAT Registration No.";

Expand Down
Loading