Skip to content

[MCP] Remove MCP feature flag check (EnableMcpAccess) #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbuyuka wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −39
Open

[MCP] Remove MCP feature flag check (EnableMcpAccess) #7403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e7b7c
Remove MCP feature flag check (EnableMcpAccess)
onbuyuka Mar 26, 2026
ae3a4d6
Remove unused using directives for System.Environment.Configuration
onbuyuka Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/System Application/App/MCP/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@
"publisher": "Microsoft",
"version": "29.0.0.0"
},
{
"id": "ae59aed1-040c-453c-9585-fe9da2f8211e",
"name": "Feature Key",
"publisher": "Microsoft",
"version": "29.0.0.0"
},
{
"id": "1b2efb4b-8c44-4d74-a56f-60646645bb21",
"name": "URI",
Expand Down
13 changes: 0 additions & 13 deletions ...ystem Application/App/MCP/src/Configuration/Codeunits/MCPConfigImplementation.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ namespace System.MCP;

using System.Azure.Identity;
using System.Environment;
#if not CLEAN28
using System.Environment.Configuration;
#endif
using System.Feedback;
using System.Reflection;
using System.Utilities;
Expand Down Expand Up @@ -1196,14 +1193,4 @@ codeunit 8351 "MCP Config Implementation"
Session.LogAuditMessage(StrSubstNo(MCPConfigurationAuditDeletedLbl, MCPConfiguration.Name, UserSecurityId(), CompanyName()), SecurityOperationResult::Success, AuditCategory::ApplicationManagement, 3, 0);
end;
#endregion

#if not CLEAN28
internal procedure IsFeatureEnabled(): Boolean
var
FeatureManagementFacade: Codeunit "Feature Management Facade";
EnableMcpAccessTok: Label 'EnableMcpAccess', Locked = true;
begin
exit(FeatureManagementFacade.IsEnabled(EnableMcpAccessTok));
end;
#endif
}
20 changes: 0 additions & 20 deletions src/System Application/App/MCP/src/Configuration/Pages/MCPConfigList.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@

namespace System.MCP;

#if not CLEAN28
using System.Environment.Configuration;
#endif

page 8350 "MCP Config List"
{
PageType = List;
Expand Down Expand Up @@ -205,19 +201,7 @@ page 8350 "MCP Config List"
}

trigger OnOpenPage()
#if not CLEAN28
var
FeatureNotEnabledErrorInfo: ErrorInfo;
#endif
begin
#if not CLEAN28
if not MCPConfigImplementation.IsFeatureEnabled() then begin
FeatureNotEnabledErrorInfo.Message := FeatureNotEnabledErr;
FeatureNotEnabledErrorInfo.AddNavigationAction(GoToFeatureManagementLbl);
FeatureNotEnabledErrorInfo.PageNo := Page::"Feature Management";
Error(FeatureNotEnabledErrorInfo);
end;
#endif
HadActiveConfigsOnOpen := not MCPConfigImplementation.HasNoActiveConfigurations();
end;

Expand All @@ -233,9 +217,5 @@ page 8350 "MCP Config List"
var
MCPConfigImplementation: Codeunit "MCP Config Implementation";
HadActiveConfigsOnOpen: Boolean;
#if not CLEAN28
FeatureNotEnabledErr: Label 'MCP server feature is not enabled. Please contact your system administrator to enable the feature.';
GoToFeatureManagementLbl: Label 'Go to Feature Management';
#endif

}
Loading