Skip to content

[Master]- Recurring billing is stuck due to an error related to updating the Subscription Line table #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neeleshsinghal wants to merge 9 commits into
base: main
Choose a base branch
from
+100 −0
Open

[Master]- Recurring billing is stuck due to an error related to updating the Subscription Line table #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81e40ac
623011 fix and automation
neeleshsinghal Mar 26, 2026
23e8094
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
neeleshsinghal Mar 27, 2026
73de5ff
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
neeleshsinghal Mar 27, 2026
077a0e0
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
neeleshsinghal Mar 27, 2026
8e4e140
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
neeleshsinghal Mar 27, 2026
5d5365d
Update src/Apps/W1/Subscription Billing/Test/Billing/RecurringBilling…
neeleshsinghal Mar 27, 2026
d673f1a
fixes
neeleshsinghal Mar 28, 2026
856028b
validate
neeleshsinghal Mar 28, 2026
07ab7b0
also add vallidate
neeleshsinghal Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Apps/W1/Subscription Billing/App/Service Commitments/Tables/SubscriptionLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1946,9 +1946,13 @@ table 8059 "Subscription Line"
LastDateInLastMonth := CalcDate(PeriodFormula, FromDate);
LastDateInLastMonth := CalcDate('<CM>', LastDateInLastMonth);
NextToDate := LastDateInLastMonth - DistanceToEndOfMonth - 1;
if NextToDate < FromDate then
NextToDate := CalcDate(PeriodFormula, FromDate) - 1;
end;
end;
end;
if NextToDate < FromDate then
NextToDate := FromDate;
end;
Comment on lines 1946 to 1956
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two separate clamps (if NextToDate < FromDate) with slightly different fallback logic, which makes the effective behavior harder to reason about (especially for boundary formulas like <0D> where CalcDate(..) - 1 still ends up < FromDate and is then overridden). Consider consolidating to a single, clearly documented normalization step at the end (or using a single helper/local variable like CandidateToDate) so the intent is explicit: compute the best-effort NextToDate, then normalize to ensure it is >= FromDate.

Copilot uses AI. Check for mistakes.

local procedure GetBillingReferenceDate() BillingReferenceDate: Date
Expand Down
96 changes: 96 additions & 0 deletions src/Apps/W1/Subscription Billing/Test/Billing/RecurringBillingDocsTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ codeunit 139687 "Recurring Billing Docs Test"
LibraryUtility: Codeunit "Library - Utility";
LibraryVariableStorage: Codeunit "Library - Variable Storage";
IsInitialized: Boolean;
NextToDateBeforeFromDateErr: Label 'CalculateNextToDate returned %1 which is before FromDate %2. This would cause billing to get stuck.', Locked = true;
NoContractLinesFoundErr: Label 'No contract lines were found that can be billed with the specified parameters.', Locked = true;
StrMenuHandlerStep: Integer;

Expand Down Expand Up @@ -2452,6 +2453,90 @@ codeunit 139687 "Recurring Billing Docs Test"
CatalogItem.TestField("Subscription Option", "Item Service Commitment Type"::"Service Commitment Item");
end;

[Test]
procedure CalculateNextToDateAlignEndOfMonthDoesNotReturnDateBeforeFromDate()
var
SubscriptionLine: Record "Subscription Line";
PeriodFormula: DateFormula;
FromDate: Date;
NextToDate: Date;
begin
// [FEATURE] [AI test]
// [SCENARIO 623011] CalculateNextToDate with "Align to End of Month" does not return date before FromDate
Initialize();

// [GIVEN] Subscription Line "SL" with Period Calculation = "Align to End of Month" and start date Jan 29
MockSubscriptionLine(SubscriptionLine);
SubscriptionLine.Validate("Period Calculation", SubscriptionLine."Period Calculation"::"Align to End of Month");
SubscriptionLine.Validate("Subscription Line Start Date", DMY2Date(29, 1, 2025));
SubscriptionLine.Modify(true);

// [WHEN] CalculateNextToDate is called with period formula <1D> from Feb 27
Evaluate(PeriodFormula, '<1D>');
FromDate := DMY2Date(27, 2, 2025);
NextToDate := SubscriptionLine.CalculateNextToDate(PeriodFormula, FromDate);

// [THEN] NextToDate is not before FromDate
Assert.IsTrue(NextToDate >= FromDate,
StrSubstNo(NextToDateBeforeFromDateErr, NextToDate, FromDate));
end;

[Test]
procedure CalculateNextToDateZeroDayFormulaReturnsFromDate()
var
SubscriptionLine: Record "Subscription Line";
PeriodFormula: DateFormula;
FromDate: Date;
NextToDate: Date;
begin
// [FEATURE] [AI test]
// [SCENARIO 623011] CalculateNextToDate with <0D> formula returns exactly FromDate (boundary case)
Initialize();

// [GIVEN] Subscription Line "SL" with Period Calculation = "Align to End of Month" and start date Jan 31
MockSubscriptionLine(SubscriptionLine);
SubscriptionLine.Validate("Period Calculation", SubscriptionLine."Period Calculation"::"Align to End of Month");
SubscriptionLine.Validate("Subscription Line Start Date", DMY2Date(31, 1, 2025));
SubscriptionLine.Modify(true);

// [WHEN] CalculateNextToDate is called with period formula <0D> from Feb 28
Evaluate(PeriodFormula, '<0D>');
FromDate := DMY2Date(28, 2, 2025);
NextToDate := SubscriptionLine.CalculateNextToDate(PeriodFormula, FromDate);

// [THEN] NextToDate is not before FromDate (should be exactly FromDate or later)
Assert.IsTrue(NextToDate >= FromDate,
StrSubstNo(NextToDateBeforeFromDateErr, NextToDate, FromDate));
end;

[Test]
procedure CalculateNextToDateMonthFormulaLeapYearDoesNotReturnDateBeforeFromDate()
var
SubscriptionLine: Record "Subscription Line";
PeriodFormula: DateFormula;
FromDate: Date;
NextToDate: Date;
begin
// [FEATURE] [AI test]
// [SCENARIO 623011] CalculateNextToDate with monthly formula and leap year Feb 29 to Mar transition does not return date before FromDate
Initialize();

// [GIVEN] Subscription Line "SL" with Period Calculation = "Align to End of Month" and start date Jan 30 (leap year 2024)
MockSubscriptionLine(SubscriptionLine);
SubscriptionLine.Validate("Period Calculation", SubscriptionLine."Period Calculation"::"Align to End of Month");
SubscriptionLine.Validate("Subscription Line Start Date", DMY2Date(30, 1, 2024));
SubscriptionLine.Modify(true);

// [WHEN] CalculateNextToDate is called with period formula <1M> from Feb 29 (leap year)
Evaluate(PeriodFormula, '<1M>');
FromDate := DMY2Date(29, 2, 2024);
NextToDate := SubscriptionLine.CalculateNextToDate(PeriodFormula, FromDate);

// [THEN] NextToDate is not before FromDate
Assert.IsTrue(NextToDate >= FromDate,
StrSubstNo(NextToDateBeforeFromDateErr, NextToDate, FromDate));
end;

#endregion Tests

#region Procedures
Expand Down Expand Up @@ -2925,6 +3010,17 @@ codeunit 139687 "Recurring Billing Docs Test"
end;
end;

local procedure MockSubscriptionLine(var SubscriptionLine: Record "Subscription Line")
var
ServiceCommitmentPackage: Record "Subscription Package";
begin
ContractTestLibrary.CreateServiceCommitmentPackage(ServiceCommitmentPackage);
SubscriptionLine.Init();
SubscriptionLine.Validate("Invoicing via", SubscriptionLine."Invoicing via"::Contract);
SubscriptionLine.Validate("Subscription Package Code", ServiceCommitmentPackage.Code);
SubscriptionLine.Insert(true);
end;

#endregion Procedures

#region Handlers
Expand Down
Loading