Skip to content

Suppress AL0432 obsolete warnings for AllObj."Object Name" field#8117

Open
SBalslev wants to merge 2 commits into
mainfrom
fix/allobj-objectname-al0432-pragma
Open

Suppress AL0432 obsolete warnings for AllObj."Object Name" field#8117
SBalslev wants to merge 2 commits into
mainfrom
fix/allobj-objectname-al0432-pragma

Conversation

@SBalslev
Copy link
Copy Markdown
Contributor

@SBalslev SBalslev commented May 12, 2026

Summary

Suppresses AL0432 compiler warnings introduced by platform PR 246852, which marks AllObj."Object Name" as ObsoleteState = Pending.

Applied #pragma warning disable/restore AL0432\ around all references in 4 codeunits:

  • PermissionImpl.Codeunit.al
  • RetenPolAllowedTblImpl.Codeunit.al
  • WebServiceManagementImpl.Codeunit.al
  • TestSuiteMgt.Codeunit.al

Related

  • Work item: AB#485120
  • Platform PR: 246852
  • Companion NAV repo PR: pending (depends on this PR being merged first)

@SBalslev SBalslev requested a review from a team as a code owner May 12, 2026 10:54
@SBalslev SBalslev requested a review from ap3rus May 12, 2026 10:54
@github-actions github-actions Bot added this to the Version 29.0 milestone May 12, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL Documentation Audit

Documentation gaps were detected in the following apps:

  • Permission-Sets: 0% documentation coverage
  • Retention-Policy: 0% documentation coverage
  • Test-Runner: 4% documentation coverage
  • Web-Service-Management: 94% documentation coverage

To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.

@SBalslev SBalslev force-pushed the fix/allobj-objectname-al0432-pragma branch from 7887923 to b6893a6 Compare May 13, 2026 11:59
Comment thread src/Tools/Test Framework/Test Runner/src/TestSuiteMgt.Codeunit.al
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@SBalslev SBalslev enabled auto-merge (squash) May 18, 2026 07:08
@SBalslev SBalslev closed this May 18, 2026
auto-merge was automatically disabled May 18, 2026 07:09

Pull request was closed

@SBalslev SBalslev reopened this May 18, 2026
@SBalslev SBalslev enabled auto-merge (squash) May 18, 2026 07:09
@github-actions
Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ Upgrade} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

AL0432 suppression hides obsolete API usage

Four separate #pragma warning disable AL0432 / restore AL0432 pairs are added around calls to RetentionPolicyLog.LogInfo, LogError, and LogWarning. Suppressing this warning silently indicates these API overloads are pending obsolescence, but no migration path or timeline comment is provided, making it easy to miss when the API is eventually removed.

Recommendation:

  • Add an inline comment for each suppression block referencing the replacement API and the target version by which migration must occur. Prioritise migrating to the non-obsolete overload.
#pragma warning disable AL0432 // TODO: Migrate to RetentionPolicyLog.LogInfo(LogCategory(), ..., Format(TableId)) before BC vXX
    RetentionPolicyLog.LogInfo(...);
#pragma warning restore AL0432

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

SBalslev and others added 2 commits May 20, 2026 14:42
Platform PR 246852 marks AllObj."Object Name" as ObsoleteState=Pending.
Add #pragma warning disable/restore AL0432 around all references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SBalslev SBalslev force-pushed the fix/allobj-objectname-al0432-pragma branch from 7a57568 to c7487f1 Compare May 20, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants