Skip to content

Bug 634911: [Subcontracting] Fix factbox UX issues - captions, DecimalPlaces, singular/plural #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChethanT merged 6 commits into from
May 21, 2026
Merged

Bug 634911: [Subcontracting] Fix factbox UX issues - captions, DecimalPlaces, singular/plural #8172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5521555
[Subcontracting] Bug 634911: Fix factbox UX issues - captions, Decima…
ChethanT May 17, 2026
44fe8ad
[Subcontracting] Bug 634911: Use Integer return type for count proced…
ChethanT May 17, 2026
ce4404b
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
ChethanT May 18, 2026
e4a2ae9
Align factbox numbers to drilldown info
ChethanT May 18, 2026
f0fe96b
Apply suggestion from @github-actions[bot]
ChethanT May 19, 2026
da84d81
Add SetLoadFields to SetFilterProductionOrderComponents
ChethanT May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcProdOFactboxMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ codeunit 99001559 "Subc. ProdO. Factbox Mgmt."
begin
if not SetProdOrderInformationByVariant(RecRelatedVariant, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo) then
exit;
ProdOrderRoutingLine.SetRange(Status, ProdOrderRoutingLine.Status::Released);
ProdOrderRoutingLine.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderRoutingLine.SetRange("Routing Reference No.", ProdOrderLineNo);
ProdOrderRoutingLine.SetRange("Routing No.", RoutingNo);
ProdOrderRoutingLine.SetRange("Operation No.", OperationNo);
SetFilterProductionOrderRouting(ProdOrderRoutingLine, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo);
ProdOrderRoutingLine.FindFirst();
ProdOrderRouting.SetTableView(ProdOrderRoutingLine);
ProdOrderRouting.Editable := false;
Expand All @@ -77,12 +73,17 @@ codeunit 99001559 "Subc. ProdO. Factbox Mgmt."
begin
if not SetProdOrderInformationByVariant(RecRelatedVariant, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo) then
exit;
SetFilterProductionOrderRouting(ProdOrderRoutingLine, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo);
exit(ProdOrderRoutingLine.Count());
end;

local procedure SetFilterProductionOrderRouting(var ProdOrderRoutingLine: Record "Prod. Order Routing Line"; ProdOrderNo: Code[20]; ProdOrderLineNo: Integer; RoutingNo: Code[20]; OperationNo: Code[10])
begin
ProdOrderRoutingLine.SetRange(Status, ProdOrderRoutingLine.Status::Released);
ProdOrderRoutingLine.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderRoutingLine.SetRange("Routing Reference No.", ProdOrderLineNo);
ProdOrderRoutingLine.SetRange("Routing No.", RoutingNo);
ProdOrderRoutingLine.SetRange("Operation No.", OperationNo);
exit(ProdOrderRoutingLine.Count());
end;

/// <summary>
Expand All @@ -92,7 +93,6 @@ codeunit 99001559 "Subc. ProdO. Factbox Mgmt."
procedure ShowProductionOrderComponents(RecRelatedVariant: Variant)
var
ProdOrderComponent: Record "Prod. Order Component";
ProdOrderRoutingLine: Record "Prod. Order Routing Line";
PageManagement: Codeunit "Page Management";
OperationNo: Code[10];
ProdOrderNo: Code[20];
Expand All @@ -101,17 +101,7 @@ codeunit 99001559 "Subc. ProdO. Factbox Mgmt."
begin
if not SetProdOrderInformationByVariant(RecRelatedVariant, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo) then
exit;
ProdOrderRoutingLine.SetRange(Status, ProdOrderRoutingLine.Status::Released);
ProdOrderRoutingLine.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderRoutingLine.SetRange("Routing Reference No.", ProdOrderLineNo);
ProdOrderRoutingLine.SetRange("Routing No.", RoutingNo);
ProdOrderRoutingLine.SetRange("Operation No.", OperationNo);
if ProdOrderRoutingLine.FindFirst() then
ProdOrderComponent.SetRange("Routing Link Code", ProdOrderRoutingLine."Routing Link Code");

ProdOrderComponent.SetRange(Status, ProdOrderComponent.Status::Released);
ProdOrderComponent.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderComponent.SetRange("Prod. Order Line No.", ProdOrderLineNo);
SetFilterProductionOrderComponents(ProdOrderComponent, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo);
PageManagement.PageRun(ProdOrderComponent);
end;

Expand All @@ -131,10 +121,26 @@ codeunit 99001559 "Subc. ProdO. Factbox Mgmt."
if not SetProdOrderInformationByVariant(RecRelatedVariant, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo) then
exit(0);

SetFilterProductionOrderComponents(ProdOrderComponent, ProdOrderNo, ProdOrderLineNo, RoutingNo, OperationNo);
Comment thread
ChethanT marked this conversation as resolved.
exit(ProdOrderComponent.Count());
end;

local procedure SetFilterProductionOrderComponents(var ProdOrderComponent: Record "Prod. Order Component"; ProdOrderNo: Code[20]; ProdOrderLineNo: Integer; RoutingNo: Code[20]; OperationNo: Code[10])
var
ProdOrderRoutingLine: Record "Prod. Order Routing Line";
begin
ProdOrderRoutingLine.SetLoadFields("Routing Link Code");
ProdOrderRoutingLine.SetRange(Status, ProdOrderRoutingLine.Status::Released);
Comment thread
ChethanT marked this conversation as resolved.
ProdOrderRoutingLine.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderRoutingLine.SetRange("Routing Reference No.", ProdOrderLineNo);
ProdOrderRoutingLine.SetRange("Routing No.", RoutingNo);
ProdOrderRoutingLine.SetRange("Operation No.", OperationNo);
if ProdOrderRoutingLine.FindFirst() then
ProdOrderComponent.SetRange("Routing Link Code", ProdOrderRoutingLine."Routing Link Code");

ProdOrderComponent.SetRange(Status, ProdOrderComponent.Status::Released);
ProdOrderComponent.SetRange("Prod. Order No.", ProdOrderNo);
ProdOrderComponent.SetRange("Prod. Order Line No.", ProdOrderLineNo);
exit(ProdOrderComponent.Count());
end;

local procedure SetProdOrderInformationByVariant(RecRelatedVariant: Variant; var ProdOrderNo: Code[20]; var ProdOrderLineNo: Integer; var RoutingNo: Code[20]; var OperationNo: Code[10]): Boolean
Expand Down
18 changes: 9 additions & 9 deletions src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcPurchFactboxMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ codeunit 99001560 "Subc. Purch. Factbox Mgmt."
/// <param name="LookUpPage">When true, opens the transfer order page; when false, only populates the temp table.</param>
/// <param name="IsReturn">When true, filters to return transfer orders; when false, filters to outbound transfer orders.</param>
/// <returns>The number of transfer lines linked to the given record.</returns>
procedure ShowTransferOrdersAndReturnOrder(RecRelatedVariant: Variant; LookUpPage: Boolean; IsReturn: Boolean): Decimal
procedure ShowTransferOrdersAndReturnOrder(RecRelatedVariant: Variant; LookUpPage: Boolean; IsReturn: Boolean): Integer
var
ProdOrderComponent: Record "Prod. Order Component";
ProdOrderLine: Record "Prod. Order Line";
Expand All @@ -239,7 +239,7 @@ codeunit 99001560 "Subc. Purch. Factbox Mgmt."
NoOfTransferHeaders: Integer;
begin
if not RecRelatedVariant.IsRecord() then
exit;
exit(0);

DataTypeManagement.GetRecordRef(RecRelatedVariant, RecRef);
ProductionOrder.SetLoadFields("No.", "Source Type");
Expand All @@ -249,33 +249,33 @@ codeunit 99001560 "Subc. Purch. Factbox Mgmt."
begin
RecRef.SetTable(ProdOrderComponent);
if not ProductionOrder.Get(ProdOrderComponent.Status, ProdOrderComponent."Prod. Order No.") then
exit;
exit(0);
if not ProdOrderLine.Get(ProdOrderComponent.Status, ProdOrderComponent."Prod. Order No.", ProdOrderComponent."Prod. Order Line No.") then
exit;
exit(0);

GetProdOrderRtngLineFromProdOrderComp(ProdOrderRoutingLine, ProdOrderComponent);
end;
Database::"Purchase Line":
begin
RecRef.SetTable(PurchaseLine);
if not ProductionOrder.Get("Production Order Status"::Released, PurchaseLine."Prod. Order No.") then
exit;
exit(0);
GetProdOrderRtngLineFromPurchaseLine(ProdOrderRoutingLine, PurchaseLine);
if ProductionOrder."Source Type" <> "Prod. Order Source Type"::Family then
if not ProdOrderLine.Get(ProdOrderRoutingLine.Status, PurchaseLine."Prod. Order No.", PurchaseLine."Prod. Order Line No.") then
exit;
exit(0);
end;
Database::"Prod. Order Routing Line":
begin
RecRef.SetTable(ProdOrderRoutingLine);
if not ProductionOrder.Get(ProdOrderRoutingLine.Status, ProdOrderRoutingLine."Prod. Order No.") then
exit;
exit(0);
if ProductionOrder."Source Type" <> "Prod. Order Source Type"::Family then
if not ProdOrderLine.Get(ProdOrderRoutingLine.Status, ProdOrderRoutingLine."Prod. Order No.", ProdOrderRoutingLine."Routing Reference No.") then
exit;
exit(0);
end;
else
exit;
exit(0);
end;

TransferLine.SetCurrentKey("Prod. Order No.", "Prod. Order Line No.", "Routing Reference No.", "Routing No.", "Operation No.");
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/Subcontracting/App/src/Process/Codeunits/SubcRoutingFactboxMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ codeunit 99001561 "Subc. Routing Factbox Mgmt."
/// </summary>
/// <param name="ProdOrderRoutingLine">The production order routing line to count linked components for.</param>
/// <returns>The count of matching production order components, or 0 if the routing link code is empty.</returns>
procedure GetNoOfLinkedComponentsFromRouting(ProdOrderRoutingLine: Record "Prod. Order Routing Line"): Decimal
procedure GetNoOfLinkedComponentsFromRouting(ProdOrderRoutingLine: Record "Prod. Order Routing Line"): Integer
var
ProdOrderComponent: Record "Prod. Order Component";
begin
Expand Down
16 changes: 5 additions & 11 deletions src/Apps/W1/Subcontracting/App/src/Process/Pages/SubcRoutingInfoFactbox.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ page 99001502 "Subc. Routing Info Factbox"
field(ShowQtyInSubcontractingOrder; SubcRoutingFactboxMgmt.GetPurchOrderQtyFromRoutingLine(Rec))
{
AutoFormatType = 0;
Caption = 'Order Quantity';
Comment thread
ChethanT marked this conversation as resolved.
Caption = 'Purch. Order Qty.';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the dependent Quantity in Subcontracting Orders of this Prod. Order Routing Line.';
trigger OnDrillDown()
Expand All @@ -41,9 +41,9 @@ page 99001502 "Subc. Routing Info Factbox"
field(ShowQtyShippedRequest; SubcRoutingFactboxMgmt.GetPurchReceiptQtyFromRoutingLine(Rec))
{
AutoFormatType = 0;
Caption = 'Quantity received';
Caption = 'Quantity Received';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the dependent Quantity received in Subcontracting Receipts of this Prod. Order Routing Line.';
ToolTip = 'Specifies the dependent Quantity Received in Subcontracting Receipts of this Prod. Order Routing Line.';
trigger OnDrillDown()
begin
ShowPurchaseReceipts();
Expand All @@ -52,19 +52,17 @@ page 99001502 "Subc. Routing Info Factbox"
field(ShowQtyInvoicedRequest; SubcRoutingFactboxMgmt.GetPurchInvoicedQtyFromRoutingLine(Rec))
{
AutoFormatType = 0;
Caption = 'Quantity invoiced';
Caption = 'Quantity Invoiced';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the dependent Quantity invoiced in Subcontracting Invoices of this Prod. Order Routing Line.';
ToolTip = 'Specifies the dependent Quantity Invoiced in Subcontracting Invoices of this Prod. Order Routing Line.';
trigger OnDrillDown()
begin
ShowPurchaseInvoices();
end;
}
field(ShowNoOfTransferOrdersFromProdOrderComp; SubcPurchFactboxMgmt.ShowTransferOrdersAndReturnOrder(Rec, false, false))
{
AutoFormatType = 0;
Caption = 'Transfer Order Lines';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the number of transfer order lines assigned to this routing line.';
trigger OnDrillDown()
begin
Expand All @@ -73,9 +71,7 @@ page 99001502 "Subc. Routing Info Factbox"
}
field(ShowNoOfReturnTransferOrdersFromProdOrderComp; SubcPurchFactboxMgmt.ShowTransferOrdersAndReturnOrder(Rec, false, true))
{
AutoFormatType = 0;
Caption = 'Return Transfer Order Lines';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the number of Return transfer order lines assigned to this routing line.';
trigger OnDrillDown()
begin
Expand All @@ -84,9 +80,7 @@ page 99001502 "Subc. Routing Info Factbox"
}
field(ShowNoOfLinkedComp; SubcRoutingFactboxMgmt.GetNoOfLinkedComponentsFromRouting(Rec))
{
AutoFormatType = 0;
Caption = 'Components';
DecimalPlaces = 0 : 5;
ToolTip = 'Specifies the number of components linked to this routing line.';
trigger OnDrillDown()
begin
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/Subcontracting/App/src/Process/Pages/SubcTransferLineFactbox.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ page 99001501 "Subc. Transfer Line Factbox"
}
field(ShowProdOrderComponents; GetNoOfProductionComponents(Rec))
{
Caption = 'Production Component';
Caption = 'Production Components';
ToolTip = 'Specifies the dependent Production Components of this Subcontracting Transfer Order.';

trigger OnDrillDown()
Expand Down
Loading