[Shopify] Persist current B2B Catalog row before disabling Sync Prices on other lines

[onbuyuka]

Summary

Reactivation of bug 630273. PR #7585 introduced a confirmation dialog for the Sync Prices toggle on B2B Catalog rows that share a catalog ID across multiple companies. PM testing showed that when the user clicked Yes on the dialog, the toggle was lost on the current row too — not just the other line — so nothing ended up with Sync Prices enabled.

Root cause

"Sync Prices" OnValidate called OtherCatalog.ModifyAll("Sync Prices", false) while the user's change Rec."Sync Prices" := true was still only in memory. The client refresh that follows the ModifyAll re-read the current row from the database (still false), clobbering the in-memory true.

The existing SyncPricesConfirmDisablesOtherLine test asserted the in-memory value of the current row after Validate + Modify(true), so it passed even though the persisted state was wrong.

Fix

Persist the current row with Modify() before the ModifyAll on other rows. This way the database already reflects the user's intent if the page refreshes.

Test plan

• Strengthen SyncPricesConfirmDisablesOtherLine to re-read Catalog2 from the database (mirroring the existing pattern used for Catalog1 in the same test) so the regression would be caught next time.
• SyncPricesCancelKeepsBothUnchanged — unchanged, still passes.
• SyncPricesNoConfirmWhenNoDuplicate — unchanged, still passes.
• All three tests pass locally against the published App with this fix.

Fixes AB#630273

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Modify() skips OnModify trigger for current record

Calling Modify() (RunTrigger defaults to false) persists the current record's Sync Prices = true before disabling other catalogs, which is the correct intent. However, any business logic registered in the table's OnModify trigger will not execute for this save, potentially leaving dependent data inconsistent.

Recommendation:

• If no OnModify trigger exists on this table (or it is safe to skip), add a comment explaining why RunTrigger = false is intentional. If OnModify contains relevant logic, use Modify(true) and guard against recursion with a flag.

// Persist current record first; RunTrigger=false is intentional to avoid
// re-entering CheckDuplicateSyncPrices and causing infinite recursion.
Modify();

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}