Follow ARM64 B <label> branches to import thunks#381
Open
RatinCN wants to merge 1 commit into
Open
Conversation
Handle ARM64 entrypoints that start with B <label> when the branch target is an import thunk recognized by the normal ADRP/LDR/BR path. Do not treat every unconditional branch as an alias: keep ordinary B <label> instructions unchanged unless the target resolves to a verified import jump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295. Already fixed in my SlimDetours in commit 3560905.
Handle ARM64 entrypoints that start with B when the branch target is an import thunk recognized by the normal ADRP/LDR/BR path.
As #295 said, If the #295 fix is merged by itself, the initial B branch will be decoded correctly and Detours can reach the label. However, if the following ADRP uses a negative page delta, it can still be affected by the existing sign-extension bug tracked in #296. Ideally, both fixes (this and #380) should be merged.