Skip to content

[SM6.10][Exec] Implement Remaining LinAlg Smoke Tests #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
V-FEXrt wants to merge 19 commits into
base: main
Choose a base branch
from
+1,171 −51
Open

[SM6.10][Exec] Implement Remaining LinAlg Smoke Tests #8366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bb28c90
[SM6.10][Exec] Implement Remaining Smoke Tests
V-FEXrt Apr 10, 2026
6b0b6a5
chore: autopublish 2026-04-10T23:27:46Z
github-actions[bot] Apr 10, 2026
740cd62
Add more tests
V-FEXrt Apr 13, 2026
b10f6ca
more tests
V-FEXrt Apr 13, 2026
44f62c3
small rename
V-FEXrt Apr 13, 2026
8f45a0c
chore: autopublish 2026-04-13T22:04:58Z
github-actions[bot] Apr 13, 2026
be24353
outer product
V-FEXrt Apr 13, 2026
c5a1f67
QueryAccumulatorLayout
V-FEXrt Apr 13, 2026
70bd8dc
Fix test oob crash
V-FEXrt Apr 13, 2026
40ad371
store not allowed on thread
V-FEXrt Apr 13, 2026
7ce1fe2
AccumulateToDescriptor
V-FEXrt Apr 14, 2026
e752af9
Fix thread shader to use SRV and Load
V-FEXrt Apr 14, 2026
3e6b534
fix the matvecmul tests
V-FEXrt Apr 14, 2026
be6102a
format
V-FEXrt Apr 14, 2026
aea86d5
groupshared load
V-FEXrt Apr 14, 2026
36faa95
store to memory
V-FEXrt Apr 14, 2026
a1805a8
Accum to memory
V-FEXrt Apr 15, 2026
6272ab9
Convert
V-FEXrt Apr 15, 2026
7649f26
format
V-FEXrt Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,8 @@ void compileShader(dxc::SpecificDllLoader &DxcSupport, const char *Source,

if (VerboseLogging) {
hlsl_test::LogCommentFmt(L"Shader Source:");
hlsl_test::LogCommentFmt(L"%c", Source);
hlsl_test::LogCommentFmt(
std::wstring(Source, Source + strlen(Source)).c_str());
Copy link
Copy Markdown
Contributor

@tex3d tex3d Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, as Source is a utf-8 char string, and you're just constructing a wide string (which assumes utf-16 for Win32 or utf-32 for nix) from the pointer, without translating the Unicode encoding.

I believe you should simply be able to change the original line to use %S instead.

Suggested change
std::wstring(Source, Source + strlen(Source)).c_str());
hlsl_test::LogCommentFmt(L"%S", Source);

Copy link
Copy Markdown
Member

@damyanp damyanp Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%c was almost certainly wrong! Plus this would do the wrong thing if the Source contained anything that looked like a format specifier.

Copy link
Copy Markdown
Contributor

@tex3d tex3d Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This suggested change didn't pick up the first line I selected, so don't take that as-is. But you can see what I was suggesting I'm sure.

}

hlsl_test::LogCommentFmt(LogFlags.str().c_str());
Expand Down
Loading
Loading