Fix macOS build by gating io_uring to Linux and adding platform fallbacks#779
Draft
Fix macOS build by gating io_uring to Linux and adding platform fallbacks#779
Conversation
Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix benchmarks not running on Mac
Fix macOS compilation by properly gating io_uring to Linux
Feb 16, 2026
Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot
AI
changed the title
Fix macOS compilation by properly gating io_uring to Linux
Fix macOS build by gating io_uring to Linux only
Feb 16, 2026
Copilot
AI
changed the title
Fix macOS build by gating io_uring to Linux only
Fix macOS build by gating io_uring to Linux and adding platform fallbacks
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_uringis Linux-specific but was compiled on all non-Windows platforms viacfg(not(windows)), breaking macOS builds.Changes
Platform detection
diskann-platform/src/lib.rs: Replacecfg(not(windows))withcfg(target_os = "linux")diskann-platform/src/linux/ssd_io_context.rs: Gate IOContext and io_uring imports behindcfg(target_os = "linux")Disk I/O fallback
diskann-disk/src/utils/aligned_file_reader/aligned_file_reader_factory.rs: UseStorageProviderAlignedFileReaderfor macOS (pure Rust, no OS-specific APIs)CI coverage
.github/workflows/ci.yml: Addmacos-latestto test matrices + dedicatedtest-benchmark-macosjobmacOS now uses the portable
StorageProviderAlignedFileReaderinstead of Linux-specific io_uring-based I/O.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.