Skip to content

Promote onAssertionFailure to beta#27282

Open
brrichards wants to merge 3 commits into
microsoft:mainfrom
brrichards:promote-on-assert
Open

Promote onAssertionFailure to beta#27282
brrichards wants to merge 3 commits into
microsoft:mainfrom
brrichards:promote-on-assert

Conversation

@brrichards
Copy link
Copy Markdown
Contributor

Summary

Promotes onAssertionFailure from @alpha to @beta

onAssertionFailure lets apps register a first chance callback that fires immediately before an assertion failure throws.

The API shape is unchanged only the release tag is updated. The comment in fluid-framework/src/index.ts is updated to match, and the affected API report files are regenerated.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings May 11, 2026 23:06
@brrichards brrichards requested a review from a team as a code owner May 11, 2026 23:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (22 lines, 8 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes onAssertionFailure from @alpha to @beta across @fluidframework/core-utils and the fluid-framework bundle, updating the source JSDoc release tag and regenerating the affected API report artifacts.

Changes:

  • Updated onAssertionFailure release tag in @fluidframework/core-utils from @alpha to @beta.
  • Updated fluid-framework re-export comment for onAssertionFailure to reflect the beta promotion and the import source.
  • Regenerated core-utils and fluid-framework API report files to reflect the new release tag.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/framework/fluid-framework/src/index.ts Updates the comment describing the re-export/import rationale for the now-@beta API.
packages/framework/fluid-framework/api-report/fluid-framework.legacy.beta.api.md Regenerated API report to include onAssertionFailure as @beta.
packages/framework/fluid-framework/api-report/fluid-framework.beta.api.md Regenerated API report to include onAssertionFailure as @beta.
packages/framework/fluid-framework/api-report/fluid-framework.alpha.api.md Regenerated API report showing the promoted @beta tag within the alpha surface.
packages/common/core-utils/src/assert.ts Promotes the JSDoc release tag for onAssertionFailure to @beta.
packages/common/core-utils/api-report/core-utils.legacy.beta.api.md Regenerated API report to include onAssertionFailure as @beta.
packages/common/core-utils/api-report/core-utils.beta.api.md Regenerated API report to include onAssertionFailure as @beta.
packages/common/core-utils/api-report/core-utils.alpha.api.md Regenerated API report showing the promoted @beta tag within the alpha surface.

Comment thread packages/framework/fluid-framework/src/index.ts Outdated
Comment thread packages/common/core-utils/src/assert.ts
Comment thread packages/common/core-utils/src/assert.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: brrichards <brrichards@microsoft.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  288641 links
    1922 destination URLs
    2172 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants