Skip to content

ci: Stop running server pipelines for the lts branch#27312

Open
alexvy86 wants to merge 1 commit into
microsoft:mainfrom
alexvy86:dont-run-server-pipelines-in-lts
Open

ci: Stop running server pipelines for the lts branch#27312
alexvy86 wants to merge 1 commit into
microsoft:mainfrom
alexvy86:dont-run-server-pipelines-in-lts

Conversation

@alexvy86
Copy link
Copy Markdown
Contributor

Description

Server releases will never be made from the LTS branch, so having the pipelines trigger for PRs to it / commits in it is not necessary. Arguably, we could remove the whole server/ folder in LTS, but I did not try to be that aggressive with this PR.

This just makes it so:

  • Those pipelines don't run for the lts branch.
  • The long-gone next branch is removed from the triggers section
  • Pipelines that used to run for PRs into release/* branches but not on commits to those branches (historian, gitrest, gitssh), now also run for commits on the branches. The routerlicious pipeline already behaves like this. Not clear why we wouldn't want the others to do the same.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings May 14, 2026 15:24
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (19 lines, 4 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Azure Pipelines trigger configuration for the server pipelines so they no longer run for the lts branch (and removes the obsolete next branch), aligning CI behavior with the fact that server releases aren’t produced from LTS. It also makes historian/gitrest/gitssh pipelines run on direct commits to release/* branches (not just PRs targeting them), consistent with the routerlicious pipeline behavior.

Changes:

  • Removed lts and next from CI/PR triggers for the server pipelines.
  • Enabled commit triggers on release/* branches for historian, gitrest, and gitssh pipelines.
  • Kept routerlicious behavior consistent while removing obsolete branch triggers.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/pipelines/server-routerlicious.yml Removes next and lts from trigger/pr branch includes; keeps release/* behavior unchanged.
tools/pipelines/server-historian.yml Removes next/lts from triggers and adds commit triggering on release/*.
tools/pipelines/server-gitssh.yml Removes next/lts from triggers and adds commit triggering on release/*.
tools/pipelines/server-gitrest.yml Removes next/lts from triggers and adds commit triggering on release/*.

Copy link
Copy Markdown
Contributor

@ChumpChief ChumpChief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, would you also merge this to the lts branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants