Skip to content

Update syncpack to v15 and move pnpm overrides to pnpm workspace file#27320

Merged
alexvy86 merged 4 commits into
microsoft:mainfrom
alexvy86:update-syncpack
May 15, 2026
Merged

Update syncpack to v15 and move pnpm overrides to pnpm workspace file#27320
alexvy86 merged 4 commits into
microsoft:mainfrom
alexvy86:update-syncpack

Conversation

@alexvy86
Copy link
Copy Markdown
Contributor

@alexvy86 alexvy86 commented May 15, 2026

Description

Update syncpack to v15 in the client release group so we can move pnpm overrides to pnpm-workspace.yaml file (also done here). Before that version, syncpack didn't fully support processing overrides in the workspace file.

Reviewer Guidance

The review process is outlined on this wiki page.

I confirmed that making changes to deps in catalogs: are flagged correctly per the syncpack configuration. Also of note, today syncpack config in the client release group already ignores everything in pnpm overrides. I confirmed that updating that config and doing something "bad" in those deps in their new location, gets flagged correctly.

Copilot AI review requested due to automatic review settings May 15, 2026 22:01
@alexvy86 alexvy86 changed the title Update syncpack Update syncpack to v15 and move pnpm overrides to pnpm workspace file May 15, 2026
Comment thread .syncpackrc.yml
- label: "Must use exact dependency ranges"
dependencies:
- "@tiny-calc/*"
# @tylerbu/markdown-magic is currently pinned to a tagged prerelease (e.g. 2.4.0-tylerbu-1); a caret range on a
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: this seems to have been a bug fixed in syncpack 15, not sure why it wasn't getting flagged before.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (226 lines, 5 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the client release group’s dependency tooling by upgrading syncpack to v15 and relocating pnpm override configuration from package.json into pnpm-workspace.yaml, aligning with the newer pnpm workspace configuration model and keeping override rationale as YAML comments.

Changes:

  • Bumped syncpack from ^14.0.2 to ^15.1.2 (and updated lockfile artifacts accordingly).
  • Moved pnpm.overrides (and associated explanatory comments) out of root package.json into root pnpm-workspace.yaml.
  • Adjusted docs and syncpack rules to reflect/allow current dependency pinning behavior.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml Adds workspace-level overrides: with in-file rationale comments.
pnpm-lock.yaml Updates lockfile entries for syncpack@15.1.2 and override materialization.
package.json Updates syncpack devDependency and removes pnpm.overrides/comment scaffolding.
build-tools/README.md Updates local testing guidance to use pnpm-workspace.yaml overrides.
.syncpackrc.yml Allows exact pinning for @tylerbu/markdown-magic in semver rules.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread pnpm-workspace.yaml
Comment on lines +94 to +99
overrides:
# biome is overridden to make review of the upgrade easier. This can be removed once merged.
"@biomejs/biome": "~2.4.5"

# node types are forced to a consistent version to avoid conflicts between globals.
"@types/node": "catalog:types"
Copy link
Copy Markdown
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)
Note that #27307 also moves these and conflict will need resolved. But that is blocked per so I think this is good to proceed.

@jason-ha jason-ha requested a review from CraigMacomber May 15, 2026 22:11
@alexvy86 alexvy86 merged commit 10af990 into microsoft:main May 15, 2026
43 checks passed
@alexvy86 alexvy86 deleted the update-syncpack branch May 15, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants