Update syncpack to v15 and move pnpm overrides to pnpm workspace file#27320
Conversation
| - label: "Must use exact dependency ranges" | ||
| dependencies: | ||
| - "@tiny-calc/*" | ||
| # @tylerbu/markdown-magic is currently pinned to a tagged prerelease (e.g. 2.4.0-tylerbu-1); a caret range on a |
There was a problem hiding this comment.
Note for reviewers: this seems to have been a bug fixed in syncpack 15, not sure why it wasn't getting flagged before.
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (226 lines, 5 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Updates the client release group’s dependency tooling by upgrading syncpack to v15 and relocating pnpm override configuration from package.json into pnpm-workspace.yaml, aligning with the newer pnpm workspace configuration model and keeping override rationale as YAML comments.
Changes:
- Bumped
syncpackfrom^14.0.2to^15.1.2(and updated lockfile artifacts accordingly). - Moved
pnpm.overrides(and associated explanatory comments) out of rootpackage.jsoninto rootpnpm-workspace.yaml. - Adjusted docs and syncpack rules to reflect/allow current dependency pinning behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds workspace-level overrides: with in-file rationale comments. |
| pnpm-lock.yaml | Updates lockfile entries for syncpack@15.1.2 and override materialization. |
| package.json | Updates syncpack devDependency and removes pnpm.overrides/comment scaffolding. |
| build-tools/README.md | Updates local testing guidance to use pnpm-workspace.yaml overrides. |
| .syncpackrc.yml | Allows exact pinning for @tylerbu/markdown-magic in semver rules. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| overrides: | ||
| # biome is overridden to make review of the upgrade easier. This can be removed once merged. | ||
| "@biomejs/biome": "~2.4.5" | ||
|
|
||
| # node types are forced to a consistent version to avoid conflicts between globals. | ||
| "@types/node": "catalog:types" |
Description
Update syncpack to v15 in the client release group so we can move pnpm overrides to
pnpm-workspace.yamlfile (also done here). Before that version, syncpack didn't fully support processing overrides in the workspace file.Reviewer Guidance
The review process is outlined on this wiki page.
I confirmed that making changes to deps in
catalogs:are flagged correctly per the syncpack configuration. Also of note, today syncpack config in the client release group already ignores everything in pnpm overrides. I confirmed that updating that config and doing something "bad" in those deps in their new location, gets flagged correctly.