build(server/routerlicious): remove invalid ESM builds#27323
Conversation
These server package pretend to have ESM support, but the generated javascript is not Node16 ES module compliant. When loaded, users are getting CJS version anyway. So, just remove appearance of ESM support.
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (33 lines, 6 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
This PR removes misleading ES module build metadata from selected Routerlicious server packages that only produce/serve CommonJS-compatible output.
Changes:
- Removes the
modulepackage entry pointing atlib/index.js. - Removes
build:esnextscripts and stops invoking them frombuild:compile. - Deletes the unused
tsconfig.esnext.jsonfiles for the affected packages.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
server/routerlicious/packages/services-client/package.json |
Removes ESNext build script and module entry. |
server/routerlicious/packages/services-client/tsconfig.esnext.json |
Deletes obsolete ESNext TypeScript config. |
server/routerlicious/packages/protocol-base/package.json |
Removes ESNext build script and module entry. |
server/routerlicious/packages/protocol-base/tsconfig.esnext.json |
Deletes obsolete ESNext TypeScript config. |
server/routerlicious/packages/local-server/package.json |
Removes ESNext build script and module entry. |
server/routerlicious/packages/local-server/tsconfig.esnext.json |
Deletes obsolete ESNext TypeScript config. |
These server package pretend to have ESM support, but the generated javascript is not Node16 ES module compliant. When loaded, users are getting CJS version anyway. So, just remove appearance of ESM support.