Skip to content

build(server/routerlicious): remove invalid ESM builds#27323

Open
jason-ha wants to merge 1 commit into
microsoft:mainfrom
jason-ha:server/remove-invalid-esm-builds
Open

build(server/routerlicious): remove invalid ESM builds#27323
jason-ha wants to merge 1 commit into
microsoft:mainfrom
jason-ha:server/remove-invalid-esm-builds

Conversation

@jason-ha
Copy link
Copy Markdown
Contributor

These server package pretend to have ESM support, but the generated javascript is not Node16 ES module compliant. When loaded, users are getting CJS version anyway. So, just remove appearance of ESM support.

These server package pretend to have ESM support, but the generated javascript is not Node16 ES module compliant.
When loaded, users are getting CJS version anyway. So, just remove appearance of ESM support.
Copilot AI review requested due to automatic review settings May 15, 2026 23:01
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (33 lines, 6 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes misleading ES module build metadata from selected Routerlicious server packages that only produce/serve CommonJS-compatible output.

Changes:

  • Removes the module package entry pointing at lib/index.js.
  • Removes build:esnext scripts and stops invoking them from build:compile.
  • Deletes the unused tsconfig.esnext.json files for the affected packages.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/routerlicious/packages/services-client/package.json Removes ESNext build script and module entry.
server/routerlicious/packages/services-client/tsconfig.esnext.json Deletes obsolete ESNext TypeScript config.
server/routerlicious/packages/protocol-base/package.json Removes ESNext build script and module entry.
server/routerlicious/packages/protocol-base/tsconfig.esnext.json Deletes obsolete ESNext TypeScript config.
server/routerlicious/packages/local-server/package.json Removes ESNext build script and module entry.
server/routerlicious/packages/local-server/tsconfig.esnext.json Deletes obsolete ESNext TypeScript config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants