Skip to content

test(tree): Fix and re-enable text op size benchmarks#27324

Merged
Josmithr merged 1 commit into
microsoft:mainfrom
Josmithr:tree/fix-text-op-benchmarks
May 18, 2026
Merged

test(tree): Fix and re-enable text op size benchmarks#27324
Josmithr merged 1 commit into
microsoft:mainfrom
Josmithr:tree/fix-text-op-benchmarks

Conversation

@Josmithr
Copy link
Copy Markdown
Contributor

The allowed variance was not accounting for the largest test variant, which is not run in correctness mode (and therefore was not caught by CI).

@Josmithr Josmithr requested review from CraigMacomber and Copilot May 15, 2026 23:05
@Josmithr Josmithr requested a review from a team as a code owner May 15, 2026 23:05
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (5 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables the TextDomain benchmark suite after adjusting the op-size variance allowance for the largest benchmark variant.

Changes:

  • Re-enables TextDomain benchmarks by removing describe.skip.
  • Increases the allowed max delta for remove-op size checks from 5 to 6 bytes.

@@ -340,7 +339,7 @@ describe.skip("TextDomain benchmarks", () => {
// TODO: Investigate whether this approximately-constant behavior is
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a work item for this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to my knowledge. I can make one though.

@Josmithr Josmithr merged commit 980e5a8 into microsoft:main May 18, 2026
35 checks passed
@Josmithr Josmithr deleted the tree/fix-text-op-benchmarks branch May 18, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants