test(tree): Fix and re-enable text op size benchmarks#27324
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (5 lines, 1 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
This PR re-enables the TextDomain benchmark suite after adjusting the op-size variance allowance for the largest benchmark variant.
Changes:
- Re-enables
TextDomain benchmarksby removingdescribe.skip. - Increases the allowed max delta for remove-op size checks from 5 to 6 bytes.
| @@ -340,7 +339,7 @@ describe.skip("TextDomain benchmarks", () => { | |||
| // TODO: Investigate whether this approximately-constant behavior is | |||
There was a problem hiding this comment.
Do we have a work item for this?
There was a problem hiding this comment.
Not to my knowledge. I can make one though.
The allowed variance was not accounting for the largest test variant, which is not run in correctness mode (and therefore was not caught by CI).