-
Notifications
You must be signed in to change notification settings - Fork 763
feat: implementation of gsl::dyn_array #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carsonRadtke
wants to merge
25
commits into
microsoft:main
Choose a base branch
from
carsonRadtke:dyn_array
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e590a2d
Initial plan
Copilot 8696c2c
Change generator from Unix Makefiles to Ninja for gcc and clang presets
Copilot 06dd56d
Use Ninja generator for msvc-base preset for consistency
Copilot 55f4956
Fix ClangCL builds by conditionally using Visual Studio generator
Copilot bff804a
Improve workflow readability with matrix include for generator config…
Copilot ffdd653
Clean up unused matrix include fields
Copilot 69a3a21
feat: implementation of gsl::dyn_array
carsonRadtke 9f20a8c
address a number of PR comments
carsonRadtke 9331f28
update generator for vs18 development
carsonRadtke 135f3c2
fold dyn_array_impl into dyn_array_base
carsonRadtke 3505f5b
remove dyn_array_traits and inline types
carsonRadtke b9ecae9
use allocator traits instead of digging into base allocator directly
carsonRadtke aad451d
no more UB in fill and copy-fill constructors
carsonRadtke e839865
copilot found some bugs. added tests for them and fixed them.
carsonRadtke c71e799
fix cpp14 build and test failures (msvc)
carsonRadtke 2a4f6db
is_same_v -> is_same + comments for static_assertion
carsonRadtke 36195f1
clang-cl support w/ ninja
carsonRadtke ddbc567
stole the clang-cl solution from pr1230
carsonRadtke 4ced9d6
make sure we have a dev shell before running cmake
carsonRadtke 4e695e7
add tests and patch more issues found by gpt-5.5
carsonRadtke cb86729
make sure helper functions are properly marked constexpr
carsonRadtke f76cfab
fix some typos
carsonRadtke 63acb93
resolve remaining todos
carsonRadtke 40d3ec1
remove GSL_HAS_* macros
carsonRadtke f3c853c
misc fixes from self-review
carsonRadtke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.