Draft
Conversation
This reverts commit fcbfc49.
This reverts commit a3a82f7.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
bpkroth
commented
Oct 29, 2025
bpkroth
commented
Oct 29, 2025
| _LOG.debug( | ||
| "%s: Establishing client connection to %s", | ||
| connection_id = SshClient.id_from_params(connect_params) | ||
| for i in range(3): # TODO: make the retry count configurable |
bpkroth
commented
Oct 29, 2025
bpkroth
commented
Oct 29, 2025
| file_handler.setLevel(logging.DEBUG) | ||
| else: | ||
| file_handler.setLevel(logging.INFO) | ||
| # logging.basicConfig(level=file_handler.level, format=LOG_FMT, datefmt=DATE_FMT) |
Contributor
Author
There was a problem hiding this comment.
fixme - only apply to console logger for pytest
bpkroth
commented
Oct 29, 2025
| # NOTE: this cache may become stale in another worker if the | ||
| # container restarts in one and the other worker doesn't notice the new port. | ||
| # Optionally check the status of the cached port before returning it. | ||
| if not check_port or self.validate_connection(): |
Contributor
Author
There was a problem hiding this comment.
TODO (possibly future PR): add a test that uses an unvalidated connection.
Useful to check for SshServer error handling.
For instance:
- Connect.
- Execute an OOB (
docker exec) command that sends a SIGSTOP command to the sshd service. - Try to issue a command over SshHostService.
- Check for timeout.
- Check for reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
SSH Test and Debugging Fixups
Description
test_remote_ssh_env#1005 byssh_service.pywait_for_docker_service_healthycheck during test fixture setup to avoid a seeming race between when docker claims containers and ready (and we therefore check the dynamic port mapping) vs when they are actually ready.Type of Change
Testing
Additional Notes (optional)