-
Notifications
You must be signed in to change notification settings - Fork 343
Generic parameter #7730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic parameter #7730
Conversation
ae7712a to
26d86fa
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7730 +/- ##
==========================================
- Coverage 59.89% 59.88% -0.01%
==========================================
Files 352 352
Lines 31806 31843 +37
==========================================
+ Hits 19051 19070 +19
- Misses 12755 12773 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ec9054 to
12463a1
Compare
12463a1 to
d6b4e4d
Compare
Add generic type arguments to ParameterBase and Cache classes for data type and instrument type.
d6b4e4d to
32ef7f9
Compare
astafan8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the type system is not as powerful for supporting this feature, and the internals of qcodes are not as cleanly implemented, this is still probably a useful addition to make towards better typed driver code and hence measurement code, so let's give it a go by the users :)
I think this undersells the feature a bit ;) Consult #7822 for some of the improvements this gives.
|

Make parameter generic in data and instrument type. This enables significantly better introspection of qcodes instruments and their data returned from parameters.
This takes the core infrastructure changes from #7655 and breaks it out into a pr with clean commits. The instrument improvements will land independently. Consult that pr for examples of improvements.