Potential fix for code scanning alert no. 6: Workflow does not contain permissions#307
Merged
Potential fix for code scanning alert no. 6: Workflow does not contain permissions#307
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/microsoft/TypeChat/security/code-scanning/6
In general, the fix is to explicitly define a
permissions:block either at the workflow root (top-level, applying to all jobs) or at the job level (per job). For this workflow there is a single jobpyright, so addingpermissions:at the job level is sufficient and clearly scoped. Since the job only needs to read the repository contents and does not intentionally write to code, issues, or PRs, we can safely restrict the token tocontents: read. If later it turns out thatjakebailey/pyright-actionor other steps require additional scopes (e.g.,checks: writeorpull-requests: write), those can be added explicitly.The single best minimal change, without altering existing functionality, is to add a
permissions:section underjobs.pyright(aligned withstrategy:andruns-on:). We’ll set:This ensures the workflow has an explicitly read-only token for repository contents, documenting intent and preventing accidental broad write access if repo/org defaults are permissive. No additional imports or external definitions are needed, as this is purely a YAML configuration change in
.github/workflows/ci.python.yml.Suggested fixes powered by Copilot Autofix. Review carefully before merging.