Skip to content

Migrate WebRTC removed types#2283

Merged
github-actions[bot] merged 2 commits intomicrosoft:mainfrom
Bashamega:migrate-rtc
Dec 13, 2025
Merged

Migrate WebRTC removed types#2283
github-actions[bot] merged 2 commits intomicrosoft:mainfrom
Bashamega:migrate-rtc

Conversation

@Bashamega
Copy link
Copy Markdown
Contributor

I have checked all of them on respec.org, so you don't have to review it one by one 😊

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2025

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Copy Markdown
Collaborator

I have checked all of them on respec.org, so you don't have to review it one by one 😊

Well no, a reviewer is supposed to check all things, even if you've done your job perfectly! (Because people make mistakes)

@Bashamega
Copy link
Copy Markdown
Contributor Author

I have checked all of them on respec.org, so you don't have to review it one by one 😊

Well no, a reviewer is supposed to check all things, even if you've done your job perfectly! (Because people make mistakes)

Okay, I know that.

@saschanaz saschanaz self-requested a review December 13, 2025 13:45
@saschanaz
Copy link
Copy Markdown
Collaborator

Cool, then I'll do my job, soon...

@saschanaz
Copy link
Copy Markdown
Collaborator

(sometimes you have to check each dictionary member name to see the source spec, because a dictionary can have multiple sources via partial dictionary)

@saschanaz
Copy link
Copy Markdown
Collaborator

LGTM, thanks!

@github-actions github-actions bot merged commit 8c87b07 into microsoft:main Dec 13, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@Bashamega
Copy link
Copy Markdown
Contributor Author

(sometimes you have to check each dictionary member name to see the source spec, because a dictionary can have multiple sources via partial dictionary)

Thank you for letting me know 😀

@Bashamega Bashamega deleted the migrate-rtc branch December 24, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants