Migrate 9 removed dictionaries#2294
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| @@ -0,0 +1,5 @@ | |||
| removals { | |||
| dictionary FontFaceDescriptors { | |||
| member variationSettings // Gecko-only as of 2022-10 | |||
There was a problem hiding this comment.
Actually this seems to be in Blink now: https://issues.chromium.org/issues/40398871
|
I have opened a second PR for the FontFace |
inputfiles/patches/html.kdl
Outdated
| } | ||
|
|
||
| dictionary FocusOptions { | ||
| member focusVisible // Gecko only as of 2022-09 |
There was a problem hiding this comment.
Added in WebKit in 2024 and Blink a few weeks ago 👀 Want to have another PR?
There was a problem hiding this comment.
I have updated it
Bashamega
changed the title
inputfiles/patches/webcodecs.kdl
Outdated
|
|
||
| dictionary EncodedVideoChunkMetadata { | ||
| member alphaSideData // Blink only as of 2023-03 | ||
| member svc // Blink only as of 2023-03 |
There was a problem hiding this comment.
svc is now in WebKit and Gecko too, another PR?
(This is why only a small size of patch is recommended)
There was a problem hiding this comment.
I have opened a pr. Sorry, I didn't think this PR was that large, lol. Lessons learned
Updated the alphaSideData member in EncodedVideoChunkMetadata to reflect a new date.
|
I have updated it @saschanaz |
| member aac | ||
| // https://w3c.github.io/webcodecs/flac_codec_registration.html | ||
| // Blink only as of 2024-09 | ||
| member flac |
There was a problem hiding this comment.
Looks like both are added in WebKit now
Removed AudioEncoderConfig dictionary and its members.
Removed aac member and updated flac comment for AudioEncoderConfig.
|
LGTM, thanks! |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
2 participants
No description provided.